fix(op-bootnode): add missed flags and enable metrics server #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
approved these changes
Sep 19, 2023
nomaxg
added a commit
to EspressoSystems/op-espresso-integration
that referenced
this pull request
Sep 25, 2023
* build(deps-dev): bump eslint-plugin-unicorn from 42.0.0 to 48.0.1 Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 42.0.0 to 48.0.1. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v42.0.0...v48.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * feat(proxyd): high availability * revert weird comment replaces * semgrep * release lock on errors, validate if local is behind remote before acquiring the lock * don't schedule updates for completed games * add concurrency metrics * labeling issue * nits * nits * fix(indexer): Fix uri util * bump version * fix: Fix json tags * build(deps-dev): bump @types/node from 20.5.0 to 20.6.1 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.6.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * feat(indexer): Enable devnet indexer as a preset * comments * fix: Include preset in presets * op-program: Use hardcoded chain config when available Fixes a bug where the host incorrectly informs the client that a custom chain config is in use. The client then attempts to read the chain config pre-image data. However, this pre-image data will not be available in on-chain contexts. * Fix a typo in derivation.md ven -> even * Fix a typo in glossary.md it's -> its * Address coordinator changes * trace provider * Add support for the output cannon trace type * Remove mutex and reorder metric updates * build(deps): bump ethereum/client-go in /ops-bedrock (ethereum-optimism#7283) Bumps ethereum/client-go from v1.13.0 to v1.13.1. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 20.5.0 to 20.6.2 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.6.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump markdownlint from 0.31.0 to 0.31.1 Bumps [markdownlint](https://github.com/DavidAnson/markdownlint) from 0.31.0 to 0.31.1. - [Changelog](https://github.com/DavidAnson/markdownlint/blob/main/CHANGELOG.md) - [Commits](DavidAnson/markdownlint@v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: markdownlint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump vitest from 0.34.1 to 0.34.4 Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 0.34.1 to 0.34.4. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v0.34.4/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * forge install: safe-contracts v1.4.1 forge install: safe-contracts v1.4.1 * bindings: Add Safe and SafeProxyFactory bindings * ci: Update semgrepignore The trailing '/' is consistent with other directories * feat(ctb): DelayedVetoable as a simple forwarder Adds a very minimal DelayedVetoable, along with tests for the _handleCall function. feat(ctb): Add actor to invariant tests feat(ctb): Simplify by reducing the amount of assembly used. feat(ctb): remove invariant tests These tests have proven complex to write due to the transparent proxy pattern. I believe that the fuzz testing is sufficient for now. * feat(ctb): Add the delay. * feat(ctb): Add vetoer and initiator roles feat(ctb): Add getters to DelayedVetoable * feat(ctb): move DelayedVetoable to L1 dir * feat(ctb): Add semver ctb: Address feedback * refactor(ctb): Remove the veto function. This simplifies the interface, and the resulting handleCall function is also cleaner, as it treats the dispatching primarily based on the caller. * feat(op-bindings): Add bindings for DelayedVetoable rebuild mips_more and preimageoracle_more bindings * feat(ctb): make vetoer and iniator getters virtual This will facilitate reusability of this contract, as a future change will put the these values in to another contract. * chore(ctb): Update semver and import path * feat(ctb): Make storage variables immutable This contract is not intended to be upgradeable. * feat(ctb): Remove ability to receive eth We don't expect to need this, and it adds complexity to the message digest which we'd prefer to avoid. * feat(ctb): Start with a delay of zero and forward instantly This allows us to include this contract in the initial deployment without having to swap it in later. feat(ctb): Add missing annotations * chore(ctb): Allow vetoing after the delay test(ctb): Some DV test clean up * fix(ctb): Address compiler warnings fix(ctb): Fix names on fuzz tests * fix(ctb): Immutables scream like a snake * fix(ctb): Properly handle return data Also adds a test that checks the return data. * refactor(ctb): Inline the _activateDelay logic This change will enable forwarding zero length data * feat(ctb): Update semver to 1.0.0 * feat(ctb): Update tests and add comments for queuedAt selector clash * locks and bindings * op-node: Fix race condition while closing OpNode (ethereum-optimism#7303) Before the `OpNode` closes it closes its data sources. If the runtime config reloader goroutine is still using the data sources then it may creates a goroutine panic. Specifically, when a `limitClient` is used, it will be fail to write an in-flight request to its semaphore after the client is closed. * introduce the rollup rpc url flag * Rollup RPC Flag * Revert "Merge pull request ethereum-optimism#6863 from ethereum-optimism/08-17-chore_indexer_Disable_flaky_indexer_tests" This reverts commit 3069791, reversing changes made to 6f36f62. * feat(ctb): Rework FaultDisputeGame resolution Initial changes to the FDG resolution function to be incentive compatible with bonds. * 🐛 fix(indexer): add retries to db connection * cleaner * cleaner again * op-challenger: Updated for the revised resolution (ethereum-optimism#7155) * op-challenger: Update to the reworked fdg resolution * uint64 resolve claim index * Update op-e2e/e2eutils/disputegame/game_helper.go Co-authored-by: refcell.eth <abigger87@gmail.com> * Update op-e2e/e2eutils/disputegame/game_helper.go Co-authored-by: refcell.eth <abigger87@gmail.com> * Retry claims resolution until done * short-circuit tryResolveClaims for empty games * bad switch case ordering --------- Co-authored-by: refcell.eth <abigger87@gmail.com> * build(deps-dev): bump @types/node from 20.5.0 to 20.6.2 (ethereum-optimism#7302) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.6.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix(op-bootnode): add missed flags and enable metrics server (ethereum-optimism#7282) * Chore: Cleanup the op-bootnode. * espresso demo setup * fix(ctb): Add vm.assume to prevent clashes on additional test cases (ethereum-optimism#7308) * fix(ctb): Add vm.assume to prevent clashes on additional test cases * Update DelayedVetoable.t.sol Co-authored-by: refcell.eth <abigger87@gmail.com> * Gas snapshot update --------- Co-authored-by: refcell.eth <abigger87@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/parser from 6.4.0 to 6.7.2 Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.4.0 to 6.7.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.2/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump viem from 1.3.1 to 1.11.0 Bumps [viem](https://github.com/wagmi-dev/viem) from 1.3.1 to 1.11.0. - [Release notes](https://github.com/wagmi-dev/viem/releases) - [Changelog](https://github.com/wagmi-dev/viem/blob/main/CHANGELOG.md) - [Commits](https://github.com/wagmi-dev/viem/compare/viem@1.3.1...viem@1.11.0) --- updated-dependencies: - dependency-name: viem dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Support old Make version by avoiding SHELLSTATUS SHELLSTATUS is only available on GNU Make 4.2 (released on 2016-05-22) and later, which is unfortunatly not installed on MacOS by default. While I am highly annoyed that Apple is unwilling to update their Make version and don't want encourage such behaviour, the change in this commit avoids this requirement and seems even simpler than the original code. * Constant time parent lookup fix. * fix l1 origin bug * remove unecessary log * Fix contract indices nit * build(deps): bump envalid from 7.3.1 to 8.0.0 Bumps [envalid](https://github.com/af/envalid) from 7.3.1 to 8.0.0. - [Release notes](https://github.com/af/envalid/releases) - [Commits](af/envalid@v7.3.1...v8.0.0) --- updated-dependencies: - dependency-name: envalid dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Track the number of claims in each game. * zero out the claim count upon resolution * Fix nits * Apply suggestions from code review Co-authored-by: Hamdi Allam <hamdi.allam97@gmail.com> * Init MM metrics * lint * build(deps-dev): bump @types/node from 20.5.0 to 20.6.3 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.6.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(indexer): remove indexer all command * build(deps-dev): bump vitest from 0.34.1 to 0.34.4 Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 0.34.1 to 0.34.4. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v0.34.4/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump glob from 10.3.3 to 10.3.5 Bumps [glob](https://github.com/isaacs/node-glob) from 10.3.3 to 10.3.5. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.3.3...v10.3.5) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * contracts-bedrock: internal devnet ProtocolVersions deployment * go: update libp2p to fix Go 1.21 build * unformat init.py, pass l1blockref down to the espresso l1 origin function, misc gitignore cleanup * Revert "update libp2p" This reverts commit 7188b32, reversing changes made to 38449bb. * update libp2p * add back ff dep * lint fixes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felipe Andrade <felipe@oplabs.co> Co-authored-by: Andreas Bigger <abigger87@gmail.com> Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local> Co-authored-by: inphi <mlaw2501@gmail.com> Co-authored-by: song <cynic2001@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: OptimismBot <112345690+OptimismBot@users.noreply.github.com> Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Will Cory <willcory10@gmail.com> Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com> Co-authored-by: Karl Bartel <karl.bartel@clabs.co> Co-authored-by: Hamdi Allam <hamdi.allam97@gmail.com> Co-authored-by: Wyatt Barnes <me@wyatt.email> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current op-bootnode has a issue: #7026
and this pr try to fix it
Tests
no additional tests for it
Additional context
none
Metadata