You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A clear and concise description of the features you're adding in this pull request.
This PR enables the new tests to be executed via the external client. In op-e2e-ext-geth-tests, all the tests within op_geth.go can be accurately initiated and tested using the external client."
Additional context
This also allows other clients, such as erigon, to be tested using the new tests in op_geth.go.
Hey @boyuan-chen, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.
@boyuan-chen Looks like mergify can't merge in the latest changes from develop which is why it got dequeued. Can you merge them in? Hopefully it will make it in before there's more changes. Otherwise if you allow maintainers to push changes to the branch mergify should be able to do it for you.
Hey @boyuan-chen, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trianglesphere
requested review from
ajsutton,
trianglesphere and
protolambda
Description
A clear and concise description of the features you're adding in this pull request.
This PR enables the new tests to be executed via the external client. In
op-e2e-ext-geth-tests, all the tests withinop_geth.gocan be accurately initiated and tested using the external client."Additional context
This also allows other clients, such as
erigon, to be tested using the new tests inop_geth.go.Link