-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-service: create a common admin API RPC and a common RPC request metrics #7482
op-service: create a common admin API RPC and a common RPC request metrics #7482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could split it out into a PR for just the admin RPC & one just for the RPC metrics, that would make it easier toreview.
I looked more on this, but this will create a two PRs that depends on another. Perhaps I'm misunderstanding, but the AdminAPI PR will inevitably touch on RPCMetrics PR, and will need to coordinate merging the two. If it's not too bothersome, I prefer to handle the two changes together in this PR. But I can still split it out into two PRs. Let me know what I should do. |
This is fine to keep at one PR. Yes, there is a dependency with changes like this, but usually they can be stacked. |
…imental flag description for enabling Admin API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY for this fix
@seungjulee could you merge in the latest from develop for CI? |
Description
op-service/metrics
fromop-node/metrics
(perhaps this needs to be a separate PR. Please let me know if I need to do so) 56a6979op-node
toop-service
. d3c3a23 Use the consolidatedAdminAPI
forop-node
andop-batcher
28aa528op-batcher
, and move it toCLIFlags
onop-service/server
. 07647f5This PR separates out
AdminAPI
functionality fromop-node
intoop-service
so that other packages likeop-batcher
that runs its own RPC server out ofop-service/rpc
can adopt the newly createdAdminAPI
without copying the logic.This work is a part of op-service refactor effort. Specifically, this work was spun out from the below comment.
Originally posted by @trianglesphere in #6895 (comment)
Tests
This is a simple refactor that does not change the existing logic. The change does not fail the existing tests.
I would love to get your opinion on where and how I should test the changes.
Additional context
cc @sebastianst @tynes @ajsutton perhaps this PR can be used as a supplementary way to evaluate my skills for the interview process.
Metadata