[txmgr] Avoid incrementing the nonce if tx signing fails #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5398 had a bug that incremented the nonce every time
craftTxis called, even if it fails. #7250 fixed the issue if gas estimation fails, but not if the sign tx call fails.This PR moves the sign call into
signWithNextNonce, and avoids incrementing the nonce if the sign call fails.Tests
Added regression test.
Additional context
We saw a batcher halt on Base mainnet because our signer infra was briefly unavailable. This caused the txmgr to submit txs with incremented nonces, which meant the L1 nodes ignored them (i.e. nonce was too high).