Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Pull in Canyon Time from superchain registry #7872

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Oct 26, 2023

Description

Activates Canyon via the superchain registry in the op-node.

Tests

Manual tests. I have confirmed that the --network flag and the --override.canyon flag work correctly (including when together).

@tynes
Copy link
Contributor

tynes commented Oct 26, 2023

This is a fun error

panic: division by zero

goroutine 4160 [running]:
math/big.nat.div({0xc001c58ba0?, 0x1?, 0x6?}, {0x0?, 0x0?, 0x0?}, {0xc001c58ba0?, 0x1?, 0x6?}, {0xc001d6a668, ...})
	math/big/natdiv.go:520 +0x32e
math/big.(*Int).QuoRem(0xc001c70b20, 0xc001c70b20, 0xc0016937e0, 0xc001693720)
	math/big/int.go:294 +0x7b
math/big.(*Int).Div(0xc001d6a668?, 0xc001c70b20?, 0xc001c70ae0?)
	math/big/int.go:305 +0x38
github.com/ethereum/go-ethereum/consensus/misc/eip1559.CalcBaseFee(0xc000a033b0, 0xc001dac000, 0x653a963f)
	github.com/ethereum/go-ethereum/consensus/misc/eip1559/eip1559.go:93 +0x547
github.com/ethereum/go-ethereum/miner.(*worker).prepareWork(0xc000412b40, 0xc000e7c790)
	github.com/ethereum/go-ethereum/miner/worker.go:987 +0x54d
github.com/ethereum/go-ethereum/miner.(*worker).generateWork(0xc000412b40, 0xc000e7c790)
	github.com/ethereum/go-ethereum/miner/worker.go:1066 +0x4f
github.com/ethereum/go-ethereum/miner.(*worker).mainLoop(0xc000412b40)
	github.com/ethereum/go-ethereum/miner/worker.go:556 +0x44c
created by github.com/ethereum/go-ethereum/miner.newWorker in goroutine 1
	github.com/ethereum/go-ethereum/miner/worker.go:294 +0x846

@trianglesphere
Copy link
Contributor Author

oh, I changed some variable json names but didn't change the config values (Eip1559DenomPostCanyon -> Eip1559DenomCanyon).

@trianglesphere
Copy link
Contributor Author

@tynes figured it out - the devnet is pulling in from the tip of op-geth, but this is based off of a branch of op-geth

@trianglesphere trianglesphere force-pushed the jg/superchain_canyon_config branch 4 times, most recently from 88f8c1e to 3237d4a Compare October 26, 2023 18:04
@trianglesphere trianglesphere force-pushed the jg/superchain_canyon_config branch from 3237d4a to b63da65 Compare October 26, 2023 18:10
@trianglesphere trianglesphere merged commit 9ac454a into develop Oct 26, 2023
@trianglesphere trianglesphere deleted the jg/superchain_canyon_config branch October 26, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants