Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing envvars setting for --override.canyon flag #7891

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Oct 27, 2023

Description

Adds missing envvars setting for the --override.canyon flag.

Tests

No tests added, small bugfix.

Additional context

We'd like to use this for our sepolia devnet which hasn't been added to the superchain registry yet. Also we use envvars rather than flags.

@mdehoog mdehoog requested a review from a team as a code owner October 27, 2023 01:43
@mdehoog mdehoog requested a review from Inphi October 27, 2023 01:43
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for finding this.

@trianglesphere trianglesphere added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@ajsutton ajsutton added this pull request to the merge queue Oct 27, 2023
Merged via the queue into ethereum-optimism:develop with commit a37f81d Oct 27, 2023
@mdehoog mdehoog deleted the michael/override-canyon-missing-envvar branch October 27, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants