op-service: cliapp lifecycle test fix, prevent race nil-ptr on app state-access #8077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test flake, as reported by @tynes:
This was caused by introspecting the state, which is available some time after
init
and beforestart
of the lifecycle, but not exactly afterinit
; this caused a rare race-condition where theStopped
state was checked on an app that was still set tonil
. Instead of using a double-pointer (yes, I know, it was a bit hacky), it now uses a channel to communicate this state. (and buffered, so it's optional to read by the test-case).