-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delta override flag #8406
Add Delta override flag #8406
Conversation
WalkthroughA new Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- op-node/flags/flags.go (2 hunks)
- op-node/service.go (2 hunks)
Additional comments: 4
op-node/flags/flags.go (2)
268-273: The addition of
DeltaOverrideFlag
is consistent with the PR objective and follows the established pattern for optional flags. Ensure that automated tests are in place to verify the functionality of this new flag.317-320: The
DeltaOverrideFlag
is correctly added to theoptionalFlags
slice, which is then included in the globalFlags
slice to be used by the CLI.op-node/service.go (2)
206-212: The implementation of the
DeltaOverrideFlag
correctly checks if the flag is set and then assigns the provided value toconfig.DeltaTime
. This matches the PR objective and the summary provided.228-234: Similarly, the
DeltaOverrideFlag
is correctly implemented in the second hunk, where the value is assigned torollupConfig.DeltaTime
if the flag is set. This is consistent with the PR objective and the summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sans my one outstanding comment.
Description
Add a hard fork activation time override flag for Delta
Tests
Manually tested on my local devnet
Summary by CodeRabbit
New Features
Enhancements