Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delta override flag #8406

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Dec 3, 2023

Description

Add a hard fork activation time override flag for Delta

Tests

Manually tested on my local devnet

Summary by CodeRabbit

  • New Features

    • Introduced a new option to manually set the Delta fork timestamp, enhancing configuration flexibility.
  • Enhancements

    • Configuration handling now includes checks for the new Delta timestamp override option, allowing for custom settings.

@ImTei ImTei requested a review from a team as a code owner December 3, 2023 12:15
@ImTei ImTei requested a review from mslipper December 3, 2023 12:15
Copy link
Contributor

coderabbitai bot commented Dec 3, 2023

Walkthrough

A new DeltaOverrideFlag has been introduced, allowing users to manually set the Delta fork timestamp, overriding default settings. This flag has been integrated into configuration parsing functions, enabling the DeltaTime parameter to be adjusted based on the flag's value. This update enhances flexibility in configuration management.

Changes

File Path Change Summary
op-node/flags/flags.go Added DeltaOverrideFlag to specify Delta fork timestamp manually.
op-node/service.go Updated parseConfig and parseRollupConfig functions to consider DeltaOverrideFlag for DeltaTime adjustments.

🐇✨
To the code, a flag we add,
For the Delta time, no longer sad.
Override it with care, set it just right,
Now the fork's timestamp shines so bright. 🌟
🐇✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 05deae5 and 15646e4.
Files selected for processing (2)
  • op-node/flags/flags.go (2 hunks)
  • op-node/service.go (2 hunks)
Additional comments: 4
op-node/flags/flags.go (2)
  • 268-273: The addition of DeltaOverrideFlag is consistent with the PR objective and follows the established pattern for optional flags. Ensure that automated tests are in place to verify the functionality of this new flag.

  • 317-320: The DeltaOverrideFlag is correctly added to the optionalFlags slice, which is then included in the global Flags slice to be used by the CLI.

op-node/service.go (2)
  • 206-212: The implementation of the DeltaOverrideFlag correctly checks if the flag is set and then assigns the provided value to config.DeltaTime. This matches the PR objective and the summary provided.

  • 228-234: Similarly, the DeltaOverrideFlag is correctly implemented in the second hunk, where the value is assigned to rollupConfig.DeltaTime if the flag is set. This is consistent with the PR objective and the summary.

Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans my one outstanding comment.

op-node/service.go Outdated Show resolved Hide resolved
@protolambda protolambda enabled auto-merge December 4, 2023 23:44
@protolambda protolambda added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2023
@refcell refcell added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@protolambda protolambda added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2023
@tynes tynes added this pull request to the merge queue Dec 6, 2023
Merged via the queue into ethereum-optimism:develop with commit c5c909a Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants