Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make shadow compressor the default compressor type #8545

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

roberto-bayardo
Copy link
Collaborator

Description

The shadow compressor better utilizes transaction space and should be used in almost all cases, so this PR makes it the default if no specific compressor is specified.

@roberto-bayardo roberto-bayardo marked this pull request as ready for review December 11, 2023 01:13
@roberto-bayardo roberto-bayardo requested a review from a team as a code owner December 11, 2023 01:13
Copy link
Contributor

coderabbitai bot commented Dec 11, 2023

Walkthrough

Walkthrough

The recent update in the codebase includes a modification to the command-line interface configuration. Specifically, the default value for a particular field, "Name," has been changed from "RatioKind" to "ShadowKind" within a function responsible for setting up CLI flags.

Changes

File Path Change Summary
op-batcher/compressor/cli.go Updated the default "Name" field value from "RatioKind" to "ShadowKind" in CLIFlags function

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change, the shadow compressor definitely has proven its stability.

@trianglesphere trianglesphere added this pull request to the merge queue Dec 11, 2023
Merged via the queue into ethereum-optimism:develop with commit 566bff8 Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants