op-node: Disable CL P2P Sync when EL Sync is enabled

[trianglesphere]

Description

The op-node will fetch missing blocks when it detects a gap in it's unsafe chain; however, op-geth when being driven with EL sync will also fetch blocks. We prefer to let op-geth do the networking because it is extensively tested and optimized.

[semgrep-app]

Semgrep found 1 nil-check-after-call finding:

• op-node/p2p/node.go: L74-167

Potential p2pmetrics nil dereference when NewBandwidthCounter is called

_{Ignore this finding from nil-check-after-call.}

[coderabbitai]

Walkthrough

Walkthrough

The changes involve the introduction of a new synchronization mode in an Ethereum Optimism node. The sync package is now imported, and a new boolean argument related to the execution layer (EL) synchronization is added to the NewNodeP2P function and the initP2P method. This argument dictates whether the EL synchronization feature is enabled. The tests in host_test.go are updated to pass a new false argument to NewNodeP2P, indicating that EL sync is disabled in these cases.

Changes

File	Change Summary
op-node/node/node.go op-bootnode/bootnode/entrypoint.go	Added sync package import; modified initP2P method to include new ELSync mode argument.
op-node/p2p/host_test.go	Updated NewNodeP2P function calls in tests to include a new false argument for EL sync.
op-node/p2p/node.go	Modified NewNodeP2P function and NodeP2P's init method to accept and conditionally use the new elSyncEnabled boolean parameter.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[codecov]

Codecov Report

Merging #8592 (0f67fdf) into develop (8cef01b) will decrease coverage by 14.40%.
Report is 7 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #8592       +/-   ##
============================================
- Coverage    34.64%   20.24%   -14.40%     
============================================
  Files          167       88       -79     
  Lines         7155     2094     -5061     
  Branches      1209      478      -731     
============================================
- Hits          2479      424     -2055     
+ Misses        4525     1642     -2883     
+ Partials       151       28      -123     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	20.24% <ø> (-0.15%)	⬇️
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 82 files with indirect coverage changes

[sebastianst]

lgtm