-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-service/txmgr: Bump fees by at least 1 wei #8713
Conversation
WalkthroughWalkthroughThe recent update involves a modification to the transaction manager's threshold calculation logic, ensuring a minimum increment of 1 wei in scenarios where network fees are extremely low. Additionally, the test suite for the transaction manager has been expanded with a new test case to verify that the gas price increment logic functions correctly, particularly ensuring the transaction's fee cap and tip are appropriately increased. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion that may be simpler but LGTM.
Edge-case during near-zero network fee conditions.
58135f4
to
aba7795
Compare
Edge-case during near-zero network fee conditions.
Description
Fixes an edge-case during near-zero network fee conditions.
Tests
Added test that failed before change.
Additional context
The lack of this causes the txmgr to not properly bump very low fees. E.g. 2 wei + 10% is still 2 wei, rounded, so no bump would happen.