Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Disable xor requirement on Network and rollup.config flags #8727

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

Disable the xor check.

@trianglesphere trianglesphere requested a review from a team as a code owner December 21, 2023 19:46
Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Walkthrough

Walkthrough

The modification in the codebase is a temporary deactivation of a check for mutually exclusive command-line flags. This adjustment suggests that the functionality requiring these flags is currently not needed or should be bypassed, with a note indicating that the check should be restored in the future.

Changes

File Path Change Summary
op-service/flags/flags.go Commented out the code block defining required exclusive flags, with a note to re-enable the check later.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@trianglesphere trianglesphere force-pushed the jg/revert_xor_network_config branch from 30efde5 to 937c66c Compare December 21, 2023 19:51
@sebastianst sebastianst added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@sebastianst sebastianst added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@sebastianst sebastianst added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit f2229b8 Dec 21, 2023
1 check passed
@sebastianst sebastianst deleted the jg/revert_xor_network_config branch December 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants