This repository was archived by the owner on Nov 2, 2021. It is now read-only.
fix: Make smoddit work for bytesN map keys #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcontracts
commented
Apr 7, 2021
| @@ -6,10 +6,15 @@ export const toHexString32 = ( | |||
| value: string | number | BigNumber | boolean | |||
| ): string => { | |||
| if (typeof value === 'string' && value.startsWith('0x')) { | |||
| return '0x' + remove0x(value).padStart(64, '0').toLowerCase() | |||
There was a problem hiding this comment.
This function probably needs to be cleaned up in the future but whatever for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
smodditso that it'll work forbytesNkeys. Underlying bug was that all values were being treated likeuintand were being right-aligned (padding the start with zeros). Solidity handlesbytesNwhereN < 32by padding the end with zeros (left-aligned). Also adds a regression test.Metadata