Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proofs: DelayedWETH Incident response improvements #453

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Proofs: DelayedWETH Incident response improvements #453

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1422b2a
DelayedWETH
wildmolasses Nov 8, 2024
e86779e
try to revert back to the old formatting
wildmolasses Nov 8, 2024
d46c9bd
revise pause to include transfers
wildmolasses Nov 8, 2024
be4ab6b
address feedback
wildmolasses Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions specs/fault-proof/stage-one/bond-incentives.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,16 @@ checks that the current `block.timestamp` is greater than the timestamp on the w
seconds and reverts if not. It also confirms that the amount being withdrawn is less than the amount in the withdrawal
request. Before completing the withdrawal, it reduces the amount contained within the withdrawal request. The original
`withdraw(wad)` function becomes an alias for `withdraw(msg.sender, wad)`.
`withdraw(guy,wad)` will not be callable when `SuperchainConfig.paused()` is `true`.
- `DelayedWETH` has a `hold()` function that allows the `owner()` address to give itself an allowance from any address.
`withdraw(guy,wad)` will not be callable when `SuperchainConfig.paused()` is `true`. Also, `withdraw(guy,wad)` is not callable
when `delayedWethPaused` is `true`, unless the caller is the `owner()`.
- `DelayedWETH` has a `setDelayedWethPaused(bool)` function that allows the `SuperchainConfig.guardian()` address to either
pause or unpause withdrawals and transfers.
- `DelayedWETH` has a `hold(guy,wad)` function that allows the `owner()` address to, for any holder, give itself an allowance
and immediately `transferFrom` that allowance amount to itself.
- `DelayedWETH` has a `recover()` function that allows the `owner()` address to recover any amount of ETH from the
contract.
- `DelayedWETH` transfers are subject to the local `delayedWethPaused` pause; users other than the owner will not be able
to transfer any tokens within the contract.

#### Sub-Account Model

Expand Down