specs: remove message expiry #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message expiry design has changed and is no longer going through the messenger. This commit removes the information to simplify the specs and implement more closely what exists today.
tynes
requested review from
0xng,
0xParticle and
skeletor-spaceman
and removed request for
0xParticle
0xParticle
approved these changes
Nov 18, 2024
|
do you think it would be worth to create a design doc with more details on expired messages? the entrypoint design doc has some comments on it, but might feel insufficient. |
|
I would like to explore another type of design for message expiry. Will follow up with a GitHub issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The message expiry design has changed and is no longer going through the
messenger. This commit removes the information to simplify the specs
and implement more closely what exists today.