Add Base Sepolia Fault Proof upgrade task #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilliams1-cb
requested review from
sbvegan,
mds1,
blmalone,
maurelian,
zchn,
anikaraghu and
emrahCoinbase
as code owners
maurelian
requested changes
Jul 18, 2024
There was a problem hiding this comment.
First item, this will need a job added to CI.
Can look at this PR as an example: https://github.com/ethereum-optimism/superchain-ops/pull/246/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
maurelian
reviewed
Jul 18, 2024
maurelian
reviewed
Jul 18, 2024
maurelian
reviewed
Jul 18, 2024
maurelian
reviewed
Jul 19, 2024
There was a problem hiding this comment.
This LGTM.
For my review I generated the tenderly simulation, and checked that the instructions in Validations.md cover the full diff.
I also checked that the Validations.md provide justification for the keys and after values, and verified the addresses set.
I left several comments to help me track my progress, which I'll resolve now.
Then there should only be one or two suggested edits, and once they are addressed I will approve the PR.
Co-authored-by: Maurelian <john@oplabs.co>
maurelian
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Base Sepolia Fault Proof upgrade task. The upgrade transactions, EXEC.md, and VALIDATION.md were based off of task
eth/009-fp-upgrade.Tests
Additional state assertions have been added to
_postCheckinSignFromJson.s.sol