Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CheckSecurityConfigs to cover all superchain targets #230

Closed
geoknee opened this issue May 13, 2024 · 1 comment
Closed

Update CheckSecurityConfigs to cover all superchain targets #230

geoknee opened this issue May 13, 2024 · 1 comment

Comments

@geoknee
Copy link
Collaborator

geoknee commented May 13, 2024

It looks like the superchain targets are hard coded into that test https://github.com/security-alliance/superchain-registry/blob/f14dc47551fdc4a5b48548a1b5bc8530d74f8ecd/scripts/CheckSecurityConfigs.s.sol#L47-L59 .

To bring the test in line with the other tests in the repo, it should loop over all superchain targets (using directories as keys).
@geoknee geoknee changed the title Update CheckSecurityConfigs to cover all superchain targets. Update CheckSecurityConfigs to cover all superchain targets May 13, 2024
@rholterhus rholterhus mentioned this issue May 14, 2024
Merged
@geoknee
Copy link
Collaborator Author

geoknee commented Jun 18, 2024

Via #257

@geoknee geoknee closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoknee