Transcribe CheckSecurityConfigs.s.sol to a Go test
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
changed the title
CheckSecurityConfigs.s.sol to a Go test
geoknee
commented
Jun 4, 2024
zchn
approved these changes
Jun 4, 2024
geoknee
commented
Jun 7, 2024
geoknee
commented
Jun 7, 2024
sebastianst
reviewed
Jun 7, 2024
sebastianst
approved these changes
Jun 9, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethereum-optimism/client-pod/issues/867
notes:
this is failing in the same way as the existing solidity test currently is (onunderlying drift was fixed, so everything is passing againmain), which is good!before merging but after review we can remove the required CI status checksdone