Skip to content

Temporarily exclude standard conduit chains from contract version checks #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Temporarily exclude standard conduit chains from contract version checks #159

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfea6d0
excludle mainnet/pontem from contract version checks
geoknee Apr 3, 2024
1ca3d60
exclude sepolia/mode from contract version checks
geoknee Apr 3, 2024
63e55eb
exclude mainnet/metal from contract version checking
geoknee Apr 3, 2024
d89341e
exclude sepolia/metal from contract version checking
geoknee Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions validation/superchain-version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ func TestSuperchainWideContractVersions(t *testing.T) {

func TestContractVersions(t *testing.T) {
isExcluded := map[uint64]bool{
919: true, // sepolia/mode L1CrossDomainMessengerProxy.version=1.4.1, https://github.com/ethereum-optimism/security-pod/issues/105
1740: true, // sepolia/metal L1CrossDomainMessengerProxy.version=1.4.1, https://github.com/ethereum-optimism/security-pod/issues/105
1750: true, // mainnet/metal L1CrossDomainMessengerProxy.version=1.4.1, https://github.com/ethereum-optimism/security-pod/issues/105
8453: true, // mainnet/base
8866: true, // mainnet/pontem L1CrossDomainMessengerProxy.version=1.4.1, https://github.com/ethereum-optimism/security-pod/issues/105
34443: true, // mainnet/mode
84532: true, // sepolia/base
90001: true, // sepolia/race, due to https://github.com/ethereum-optimism/superchain-registry/issues/147
Expand Down