Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rust bindings #259

Merged
merged 9 commits into from
Jun 6, 2024
Merged

feat: rust bindings #259

merged 9 commits into from
Jun 6, 2024

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Jun 4, 2024 •
edited
Loading

Description

Adds minimal rust bindings to the superchain registry package.

  1. Static files are embedded with the help of include_dir in the crate's binary
  2. They are loaded lazily as lazy_statics and exported for usage.

Ctor could be used alternatively of lazy_static, however I feel like lazy evaluation is an important feature and consider it preferable (and less experimental) than global constructors.

Tests

  • decode statically embedded files into the new superchain types
  • more tests are still needed to make sure everything is decoded properly

Metadata

@refcell refcell requested review from clabby and refcell June 5, 2024 13:11
refcell
refcell reviewed Jun 5, 2024
View reviewed changes
bindings/rust/README.md Outdated Show resolved Hide resolved
refcell
refcell reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I think if we're able to pull in alloy types here, we should be good to get this merged and continue iterating on what's in trunk.

merklefruit
merklefruit commented Jun 5, 2024
View reviewed changes
bindings/rust/src/init.rs Outdated Show resolved Hide resolved
@merklefruit merklefruit marked this pull request as ready for review June 5, 2024 21:52
@merklefruit merklefruit requested a review from a team as a code owner June 5, 2024 21:52
@merklefruit merklefruit requested a review from tynes June 5, 2024 21:52
refcell
refcell approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I think it's reasonable to get this great start in trunk and keep iterating + adding tests.

clabby
clabby approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Let's get final approval from @geoknee / @sbvegan, then I think we're good to merge :)

@refcell refcell merged commit a62fd38 into ethereum-optimism:main Jun 6, 2024
8 checks passed
@merklefruit merklefruit deleted the feat/rust-bindings branch June 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@clabby clabby clabby approved these changes

@tynes tynes Awaiting requested review from tynes tynes was automatically assigned from ethereum-optimism/go-reviewers

Assignees

@merklefruit merklefruit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dep(superchain-registry): Rust bindings
3 participants
@merklefruit @clabby @refcell