Rename plasma to altDA #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseguy
force-pushed
the
ss/rename-plasma
branch
2 times, most recently
from
7fc039e to
a5c069c
Compare
geoknee
reviewed
Aug 13, 2024
geoknee
reviewed
Aug 13, 2024
geoknee
reviewed
Aug 13, 2024
Collaborator
geoknee
left a comment
geoknee
left a comment
There was a problem hiding this comment.
The rollup config diff tool is failing, and nowadays that failure is not expected/acceptable in general.
I think the problem is that the tool cannot generate configs on main, since the tool only checks out the superchain folder from main and retains the rest of the code from the PR branch. That might be an easy fix -- @bitwiseguy do you think you could look into it?
bitwiseguy
force-pushed
the
ss/rename-plasma
branch
from
d8880da to
c27b229
Compare
Contributor
|
Detected nonzero diff in rollup config. This PR modifies the configuration of at least one chain in the registry, which may or may not have been intended. You can see the detail here. |
geoknee
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
Complementary monorepo pr: ethereum-optimism/optimism#11370