Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Pandapip1 authored Sep 1, 2022
1 parent 9b388e6 commit 6d27b0a
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions EIPS/eip-rich-site-proposed-contract-metadata.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ author: Dan Finlay (@danfinlay)
discussions-to: https://ethereum-magicians.org/t/eip-rich-site-proposed-contract-metadata/9635
status: Draft
type: Standards Track
category: Interface
category: ERC
created: 2022-06-15
---

Expand Down Expand Up @@ -52,6 +52,7 @@ Any method that involves an address MAY include a new OPTIONAL parameter `propos
`contractId` would be some kind of cross chain address format.
`ContractData` would be some kind of type that is enough to render transaction names for methods called.
- Today TX Insight uses a full Truffle Decoder output to render this, which includes lots of compiler info that we would not need here.

```typescript
type TxOptionsEnhancement = {
proposedContracts: {
Expand All @@ -62,7 +63,8 @@ type TxOptionsEnhancement = {
}
}
}
```
e```
Wallets MUST store the recommending site & time along with this data for forensic purposes.
The user SHOULD be able to adjust the proposed names in the confirmation, to avoid collisions, and help personalize their local context.
Any subsequent confirmations that are displaying the proposed contracts' names SHOULD show the proposed names.
Expand Down

0 comments on commit 6d27b0a

Please sign in to comment.