Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions don't run for first time contributors #5310

Closed
SamWilsn opened this issue Jul 22, 2022 · 27 comments · Fixed by #5312
Closed

GitHub actions don't run for first time contributors #5310

SamWilsn opened this issue Jul 22, 2022 · 27 comments · Fixed by #5312
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. r-ci Relates to the CI

Comments

@SamWilsn
Copy link
Contributor

Pull Request

#5164

What happened?

eipw and friends didn't run automatically for this PR since this is the authors first time contributing.

Relevant log output

No response
@Pandapip1
Copy link
Member

Pandapip1 commented Jul 22, 2022 •
edited
Loading

This is due to a branch protection rule a setting. CC @MicahZoltu @lightclient

image

@SamWilsn
Copy link
Contributor Author

I don't think so. I think this is just the default for GitHub actions.

@Pandapip1 Pandapip1 mentioned this issue Jul 22, 2022
Merged
@MicahZoltu
Copy link
Contributor

Any idea what happens if a first-time-contributor submits a PR that touches a .workflow file, such as to print out secrets? While the number of second time editors to this repo is incredibly high, at least the current setup makes it a little harder to execute such an attack...

@MicahZoltu
Copy link
Contributor

We should probably limit the set of actions that can be run to protect against that attack vector more broadly, though I think there are actions that let you run arbitrary shell commands so I'm not sure that would help much.

@Pandapip1
Copy link
Member

Needs reopening.

@MicahZoltu MicahZoltu reopened this Jul 27, 2022
@MicahZoltu
Copy link
Contributor

We should probably limit the set of actions that can be run to protect against that attack vector more broadly, though I think there are actions that let you run arbitrary shell commands so I'm not sure that would help much.

The prescience of this comment is alarming. 😬

@Pandapip1 Pandapip1 changed the title [Bug]: GitHub actions don't run for first time contributors GitHub actions don't run for first time contributors Aug 23, 2022
@Pandapip1 Pandapip1 added the bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. label Aug 23, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 31, 2022
@Pandapip1
Copy link
Member

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 8, 2022
@Pandapip1
Copy link
Member

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 9, 2022
@Pandapip1 Pandapip1 added the r-ci Relates to the CI label Sep 10, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 19, 2022
@Pandapip1
Copy link
Member

Still an issue :|

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 20, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 27, 2022
@Pandapip1
Copy link
Member

Still an issue

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 28, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 6, 2022
@Pandapip1
Copy link
Member

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 7, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 15, 2022
@Pandapip1
Copy link
Member

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 18, 2022
@poojaranjan poojaranjan mentioned this issue Oct 19, 2022
Closed
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 25, 2022
@Pandapip1
Copy link
Member

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 26, 2022
@lightclient
Copy link
Member

What do we need to do to resolve this?

@Pandapip1
Copy link
Member

Unsure.

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 10, 2022
@Pandapip1
Copy link
Member

Still an issue :|

@github-actions github-actions bot removed the w-stale Waiting on activity label Nov 11, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 19, 2022
@Pandapip1
Copy link
Member

I think this is still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Nov 20, 2022
@Pandapip1
Copy link
Member

I actually haven't seen this happen recently, so I'll assume that something solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. r-ci Relates to the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvify GitHub Action Pandapip1/EIPs
5 participants
@MicahZoltu @lightclient @Pandapip1 @SamWilsn and others