-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5164: Cross-Chain Execution #5164
Conversation
A critical exception has occurred: |
Thanks @MicahZoltu! I will review and update. |
- Supports public bridges - Make `relayCalls` payable - Add gas limit and caller - Added EIP feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Just need to clear up the last three comments and get eipw
to run (#5310, cc. @MicahZoltu & @lightclient)
## Abstract | ||
|
||
This specification defines a cross-chain execution interface for EVM-based blockchains. Users of this spec will be able to have contracts on one chain call contracts on another chain. The specification is agnostic of the transport layer, so that implementations can choose how they relay the execution. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if the abstract gave a tad more of a technical overview, and a hint of how the cross-chain communication works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting ready to turn my attention back to this. I will add more background!
The commit a641fed (as a parent of 18a613e) contains errors. Please inspect the Run Summary for details. |
Head branch was pushed to by a user without write access
The We have realized during the implementation of this EIP that bridges most often communicate with only one executor contract on the receiving chain. Applications can decide to set the |
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay for a draft
* Added Cross-Chain Execution EIP * Integrated pull request review changes for EIP 5164 * Added discussion-to link * Updated EIP-5164 according to discussion - Supports public bridges - Make `relayCalls` payable - Add gas limit and caller - Added EIP feedback * Latest Pull Request changes * Changed ERC->EIP * EIP-5164: Fixed up for EIPW bot * EIP-5164: add ReceiverAware specification * EIP-5164: fix EIP-N linting * EIP-5164: improve CrossChainExecutor description * EIP-5164: improve ExecutorAware description Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: remove executor from relayCalls * EIP-5164: reword RelayCalls requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword RelayedCalls requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword GasLimitTooHigh requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword Authentication requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword Authentication requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword CallFailure requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword ExecutedCalls requirements Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: reword Security Considerations Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * EIP-5164: update rationale Co-authored-by: Pierrick Turelier <pierrick@turelier.com> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
The initial draft for the Cross-Chain Execution EIP! 🎉 🎉
Once an EIP number is assigned, I will create a corresponding topic in Ethereum Magicians.
Note: the EIP was born out of a conversation on Ethereum Magicians.