Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1109: Remove call costs for precompiled contracts #1109

Merged
merged 7 commits into from
May 22, 2018

Conversation

jbaylina
Copy link
Contributor

No description provided.

EIPS/eip-1109.md Outdated
eip: 1109
title: Remove CALL costs for precompiled contracts
author: Jordi Baylina (@jbaylina)
discussions-to: jordi@baylina.cat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a public URL where people can discuss.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

EIPS/eip-1109.md Outdated
author: Jordi Baylina (@jbaylina)
discussions-to: jordi@baylina.cat
status: Draft
type: Core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to supply a category as well as a type; see EIP 0 or EIP-X for guidance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jbaylina jbaylina changed the title Remove call costs for precompiled contracts EIP-1109: Remove call costs for precompiled contracts May 22, 2018
EIPS/eip-1109.md Outdated
eip: 1109
title: Remove CALL costs for precompiled contracts
author: Jordi Baylina (@jbaylina)
discussions-to: https://github.com/ethereum/EIPs/pull/1109
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use this PR as a persistent discussion venue - either open an issue for discussion, or a thread on Ethereum Magicians.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Contains new file EIPS/eip-1109.md
  • EIP 1087 requires approval from one of (@Arachnid)

@Arachnid Arachnid merged commit b26ff65 into ethereum:master May 22, 2018
- Call to defined smart contract with a value!=0 on the call.
- Call to undefined smart contract with a value!=0 on the call.
- Normal call with remaining gas<700 but gas>[the cost of the call].

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to a precompiled contract which forwards all gas but

  • 600
  • 700
  • 701

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Jul 19, 2018
* Remove call costs for precompiled contracts

* EIP number added and file name changed

* Fixed discussion-to field

* Fixed type and category fields

* discussion-to field changed to ethereum-magicians

* Change a bad change

* Changed the discussion link
@@ -0,0 +1,55 @@
---
eip: 1109
title: Remove CALL costs for precompiled contracts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just throwing it out there: Another option is to keep the default behavior for the *CALL* opcodes for backwards compatibility, but introduce a PRECOMPILE opcode that removes the excessive gas costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants