-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1276: Eliminate Difficulty Bomb and Adjust Block Reward on Constantinople Shift #1276
Conversation
Same comment as all of the others. This should be two separate EIPs, not one EIP. Everyone seems to want the block reward to be a function of time, and if that is your intent then create an EIP that proposes changing the block reward to be a function of time rather than bundling reward changes with ice age changes. |
@MicahZoltu Well I remember that EIP-649 was one EIP with difficulty bomb delay and reward adjustment, but why not for constantinople?? https://github.com/ethereum/EIPs/blob/master/EIPS/eip-649.md |
Just because we (community) made a mistake in the past doesn't mean we should repeat that mistake over and over again. 😉 |
@MicahZoltu @5chdn Like we did a bomb delay and we are doing again? 😄 |
I'm not sure what you are arguing. If you believe that combining the ice age changes and the block reward in the same EIP is a good idea, that is fine but I think you'll get more traction if your argument is more than "it is what we did last time". There is an EIP that removes the difficulty bomb entirely already, https://eips.ethereum.org/EIPS/eip-1240. My recommendation is that if you want to adjust the block reward you create an EIP that does just that and propose it. You could even (optionally) write the EIP such that if EIP-1240 is implemented then the block reward formula is |
@5chdn Yes, it is now EIP-1128 = EIP-1240 + EIP-1277 What a combination 😂 |
Please use #1276 |
@5chdn I have neither the time nor inclination to sit through 1.5 hours of discussion that I don't care about just so I can participate in the 5 minutes of discussion I do care about. Also, the meeting is quite late in the day for me (22:00) which makes it somewhat inconvenient to attend. This is why I very much prefer discussion happen on forums (Ethereum Magicians, ETH Research, GitHub issues, etc.). I'll post commentary based on my reading of the Core Devs meeting elsewhere (in a more appropriate place to hold discussion). |
Abstract: Starting with
CNSTNTNPL_FORK_BLKNUM
the client will calculate the difficulty without considering the current block number. Furthermore, block rewards will be adjusted to a base of 2 ETH, uncle and nephew rewards will be adjusted accordingly.Read the draft here: eip-1276.md
Orthogonal intention and not compatible with #1234 .