Replaced sha3 with keccak256 in EIP-712 assets #1521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woodpile37
added a commit
to Woodpile37/EIPs
that referenced
this pull request
Nov 4, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade chai from
4.3.6 to 4.3.10.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **4 versions** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-09-28.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>chai</b></summary>
<ul>
<li>
<b>4.3.10</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.10">2023-09-28</a></br><p>This
release simply bumps all dependencies to their latest non-breaking
versions.</p>
<h2>What's Changed</h2>
<ul>
<li>upgrade all dependencies by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/keithamus/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/keithamus">@ keithamus</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1916961847" data-permission-text="Title is private"
data-url="chaijs/chai#1540"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1540/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1540">#1540</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.9...v4.3.10"><tt>v4.3.9...v4.3.10</tt></a></p>
</li>
<li>
<b>4.3.9</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.9">2023-09-27</a></br><p>Upgrade
dependencies.</p>
<p>This release upgrades dependencies to address <strong><a
href="https://www.cve.org/CVERecord?id=CVE-2023-43646"
rel="nofollow">CVE-2023-43646</a></strong> where a large function name
can cause "catastrophic backtracking" (aka ReDOS attack) which can cause
the test suite to hang.</p>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.8...v4.3.9"><tt>v4.3.8...v4.3.9</tt></a></p>
</li>
<li>
<b>4.3.8</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.8">2023-08-24</a></br><h2>What's
Changed</h2>
<ul>
<li>4.x.x: Fix link to commit logs on GitHub by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/bugwelle/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/bugwelle">@ bugwelle</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1442318999" data-permission-text="Title is private"
data-url="chaijs/chai#1487"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1487/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1487">#1487</a></li>
<li>build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 by <a
class="user-mention notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/dependabot">@ dependabot</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1442803192" data-permission-text="Title is private"
data-url="chaijs/chai#1488"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1488/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1488">#1488</a></li>
<li>Small typo in test.js by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/mavaddat/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/mavaddat">@ mavaddat</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1154733117" data-permission-text="Title is private"
data-url="chaijs/chai#1459"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1459/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1459">#1459</a></li>
<li>docs: specify return type of objDisplay by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/scarf005/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/scarf005">@ scarf005</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1476032440" data-permission-text="Title is private"
data-url="chaijs/chai#1490"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1490/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1490">#1490</a></li>
<li>Update CONTRIBUTING.md by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/matheus-rodrigues00/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/matheus-rodrigues00">@
matheus-rodrigues00</a> in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1732701131"
data-permission-text="Title is private"
data-url="chaijs/chai#1521"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1521/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1521">#1521</a></li>
<li>Fix: update exports.version to current version by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/peanutenthusiast/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/peanutenthusiast">@
peanutenthusiast</a> in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1864098264"
data-permission-text="Title is private"
data-url="chaijs/chai#1534"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1534/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1534">#1534</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/bugwelle/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/bugwelle">@ bugwelle</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1442318999"
data-permission-text="Title is private"
data-url="chaijs/chai#1487"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1487/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1487">#1487</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mavaddat/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/mavaddat">@ mavaddat</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1154733117"
data-permission-text="Title is private"
data-url="chaijs/chai#1459"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1459/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1459">#1459</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/scarf005/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/scarf005">@ scarf005</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1476032440"
data-permission-text="Title is private"
data-url="chaijs/chai#1490"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1490/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1490">#1490</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/matheus-rodrigues00/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/matheus-rodrigues00">@
matheus-rodrigues00</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1732701131" data-permission-text="Title is private"
data-url="chaijs/chai#1521"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1521/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1521">#1521</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/peanutenthusiast/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/peanutenthusiast">@
peanutenthusiast</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1864098264" data-permission-text="Title is private"
data-url="chaijs/chai#1534"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1534/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1534">#1534</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.7...v4.3.8"><tt>v4.3.7...v4.3.8</tt></a></p>
</li>
<li>
<b>4.3.7</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.7">2022-11-07</a></br><h2>What's
Changed</h2>
<ul>
<li>fix: deep-eql bump package to support symbols comparison by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/snewcomer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/snewcomer">@ snewcomer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1438632532" data-permission-text="Title is private"
data-url="chaijs/chai#1483"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1483/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1483">#1483</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.6...v4.3.7"><tt>v4.3.6...v4.3.7</tt></a></p>
</li>
<li>
<b>4.3.6</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.6">2022-01-26</a></br><p>Update
loupe to 2.3.1</p>
</li>
</ul>
from <a href="https://snyk.io/redirect/github/chaijs/chai/releases">chai
GitHub release notes</a>
</details>
</details>
<details>
<summary><b>Commit messages</b></summary>
</br>
<details>
<summary>Package name: <b>chai</b></summary>
<ul>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/744a16e1cc4e8a9c6d4499e1e520a0bc4c80ec18">744a16e</a>
4.3.10</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/0ccd823cb3ee6a433156c4e23cc67de79d4f368d">0ccd823</a>
upgrade all dependencies (ethereum#1540)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/923d0a48fc59a910ecee37c85535379520a3e1b6">923d0a4</a>
4.3.9</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/1a0f8872711f64b8353c30ebcfdf0ceeab404bab">1a0f887</a>
make</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/a141e5739ab32ae579cd2df2eb745dbf1375ac27">a141e57</a>
upgrade deps</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/d9ff2c6d3e3f306b8b76e081cc892f42bf551b26">d9ff2c6</a>
4.3.8</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/8d3205b27e706f188f1c4f548d23b989eb60a0db">8d3205b</a>
build</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/b351dc09440e87917f25daa8d49dfb8866efc704">b351dc0</a>
Fix: update exports.version to current version (ethereum#1534)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/1a8247f30dbe0f54268a9748ae673caec75d6bfe">1a8247f</a>
Update CONTRIBUTING.md (ethereum#1521)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/3a8c49a70733ac7f4570925415e9a8544e2ee1c3">3a8c49a</a>
docs: specify return type of objDisplay (ethereum#1490)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/b45512409768514aac931a54da628adf2d27a934">b455124</a>
test: fix typo in test.js (ethereum#1459)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/98f42337562429353e829ebc4f85a00622087fce">98f4233</a>
build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (ethereum#1488)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/acd16e0033591d849b82f0700fd223072ebf420c">acd16e0</a>
chore: 4.x.x: Fix link to commit logs on GitHub (ethereum#1487)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/3c947a7f33b021730ea68a52bd15712fe57134be">3c947a7</a>
build</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/775f50958422278933db6efefa1ec2526191e632">775f509</a>
4.3.7</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/8e780b44f321056c960f00b94b4c2aefa3392c21">8e780b4</a>
fix: deep-eql bump package to support symbols comparison (ethereum#1483)</li>
</ul>
<a
href="https://snyk.io/redirect/github/chaijs/chai/compare/529b8b527ba99454471ac67d6aebca9d96cb5dd9...744a16e1cc4e8a9c6d4499e1e520a0bc4c80ec18">Compare</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkMDQzOThiZC0wYzlmLTQyMmEtOGEyZi0yNTQ2NDNjMDY2MDMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQwNDM5OGJkLTBjOWYtNDIyYS04YTJmLTI1NDY0M2MwNjYwMyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14/settings/integration?pkg=chai&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"d04398bd-0c9f-422a-8a2f-254643c06603","prPublicId":"d04398bd-0c9f-422a-8a2f-254643c06603","dependencies":[{"name":"chai","from":"4.3.6","to":"4.3.10"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"3a4e6031-90ad-4f6e-a8f2-e52f97555f14","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":4,"publishedDate":"2023-09-28T09:50:37.566Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the latest commits on
ethereumjs-util,sha3has been renamed tokeccak256to avoid confusion.