Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong Input Length - ERC165 Example #1640

Merged
merged 3 commits into from
May 22, 2019
Merged

Commits on Dec 7, 2018

  1. Wrong input size - noThrowCall ERC165

    Input should be 36 bytes (4 signature bytes + 32 bytes parameter)
    
    Solidity 5 validates the length of msg.data, reverting on the 32 bytes input, all contracts using the broken 'doesContractImplementInterface' will not be able to read an ERC165 implementation targetting Solidity 5.
    
    A legacy-compatible strategy should be defined to make all the "ERC165 readers" sending a 32 bytes sized data compatible with ERC165 contracts compiled targeting this new version of the compiler.
    
    A possible solution could be to add a keyword on Solidity to disable the validation of the calldata length.
    Agustin Aguilar authored Dec 7, 2018
    Configuration menu
    Copy the full SHA
    ac24145 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Configuration menu
    Copy the full SHA
    47962c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. EIP 1640 -> PR 1640

    Agusx1211 authored Apr 8, 2019
    Configuration menu
    Copy the full SHA
    1eca391 View commit details
    Browse the repository at this point in the history