Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add temporal replay protection #1681

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 8, 2019

This PR adds an EIP about temporal replay protection, basically valid-until in the form of a timestamp to transactions.

@axic
Copy link
Member

axic commented Jan 8, 2019

It may make sense to have a look at #599, which seems to be similar, and has some discussions.

@holiman
Copy link
Contributor Author

holiman commented Jan 8, 2019

Oh thanks @axic , I vaguely recalled there being something like it already, but didn't find it. It differs a bit, though, since this one uses timestamp instead of block numbers, to make it more 'sane' from the perspective of an offline signer. I'll add it as a reference though.

@holiman
Copy link
Contributor Author

holiman commented Jan 31, 2019

I've added a reference to the EIP by @Arachnid now, and also some more rationale about why this EIP uses utc time instead of blocknumbers.

@jvluso
Copy link

jvluso commented Feb 9, 2019

We should include that the address of a contract created by an EOA in a transaction with replay protection depends on the valid-until date in addition to depending on the nonce so that once dust account removal starts, contracts cannot be redeployed at the same address after being self destructed.

@nicksavers nicksavers merged commit ac0e1f9 into ethereum:master Mar 8, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
@moodysalem
Copy link
Contributor

moodysalem commented Jun 1, 2020

Can we make this EIP more user-friendly? 'temporal replay protection' sounds a lot more complicated, and it sounds like it is security related similar to the replay protection EIP, vs. 'transaction deadlines' which is just a badly needed UX feature

I ask because I want to bring this up in the next core developer call

Also I prefer the word deadline to valid-until

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants