Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC820: Supersed ERC820 with ERC820a #1758

Closed
wants to merge 1 commit into from
Closed

Conversation

0xjac
Copy link
Contributor

@0xjac 0xjac commented Feb 18, 2019

  • Mark ERC820 as superseded
  • Add ERC820a and set to last call
  • Adapt travis validation script to accept ERC820a
  • change Jacques' email due to a bug with github search (which made the
    previous email unfindable)

- Mark ERC820 as superseded
- Add ERC820a and set to alst call
- Adapt travis validation script to accept ERC820a
- change Jacques' email due to a bug with github search (which made the
  previous email unfindable)
@0xjac
Copy link
Contributor Author

0xjac commented Feb 18, 2019

@Arachnid could you go over this PR and merge it? Thanks.

@axic
Copy link
Member

axic commented Feb 18, 2019

I think it is a bad idea to introduce an alternative naming scheme (at least without codifying that in EIP-1).

I suggest to create a new EIP with a brand new number, which supersedes 820. However I think the supersedes tag can only be added once the new EIP was Final and all the authors agree that the old one is discouraged against and hence must be superseded.

@0xjac
Copy link
Contributor Author

0xjac commented Feb 18, 2019

@axic If you are just talking about the filename, I am happy to rename it but I am not sure to what. We have already discussed using a new EIP number and I find it counter intuitive, we are not introducing a new EIP, we are fixing an existing one which was broken by the Solidity 0.5 update.

Regarding the superseding, everyone agrees (the authors and the community) that ERC820 needs to be superseded. It has been marked as such already to make it clear.

Also can we please keep the discussion over at #820. Thanks

@Arachnid
Copy link
Contributor

You can't invent a new nomenclature '820a'. If you want to change a final EIP, you need to issue a new EIP, with a new number, and mark it as replacing 820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants