Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC1820: Move to final, mark 820 as superseded #1919

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

0xjac
Copy link
Contributor

@0xjac 0xjac commented Apr 6, 2019

There was no significant changes and no functional changes to ERC1820.
The only change made was a change to the natspec comments on the registry.
(See 556cc58 for the changes.)

Thanks to @mcdee and @fulldecent for the reviews.

@nicksavers Could you please merge the PR and make 1820 final? Thanks

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1820 state from Last Call to Final
  • EIP 820 is in state Final, not Draft or Last Call

@nicksavers nicksavers merged commit c8f3b4e into ethereum:master Apr 6, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants