Add EIP-1654: Off-chain dapp-wallet authentication process #2119
Conversation
|
@axic thanks for commenting |
EIPS/eip-1654.md
Outdated
| The contract MUST implement the following method: | ||
|
|
||
| ```Solidity | ||
| function isValidSignature(bytes32 hash, bytes _signature) returns(bytes4 magicValue); |
There was a problem hiding this comment.
The pseudocode above uses challengeHash, why not use it here?
There was a problem hiding this comment.
Right, the pseudocode describes the challenge-response flow needed for authentication flow. However, the contract interface is more generic, and could be used for any off-chain signature verification flow.
|
@axic thanks for second review! |
axic
changed the title
|
@axic sorry for re-pinging |
|
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
The "request for comments" phase on EIP 1654 has converged to a stable spec on #1654 .
Additionally, the process in this spec has been implemented successfully by a large number of dapps, including:
Crypto Kitties - https://www.cryptokitties.co/
Cheeze Wizards - https://www.cheezewizards.com/
MyCryptoHeroes - https://www.mycryptoheroes.net/
Etheremon - https://www.etheremon.com/
Megacryptopolis - https://www.megacryptopolis.com/
Blockchain Cuties Universe - https://blockchaincuties.com/
Hyperdragons - https://hyperdragons.alfakingdom.com/