Ready for last call. #2189
Ready for last call. #2189
Conversation
| @@ -1,27 +1,27 @@ | |||
| --- | |||
| eip: 615 | |||
| title: Subroutines and Static Jumps for the EVM | |||
| status: Draft | |||
| status: Last Call | |||
There was a problem hiding this comment.
Last call deadline field is missing.
There was a problem hiding this comment.
review-period-end: is missing indeed
According to EIP-1 that's normally 14 days, but I suppose it's up to the author.
There was a problem hiding this comment.
I think EIP-1 leaves the date to the discretion of the Editor, not the author.
|
As a side note, I don't think editors should create branches on this repo. |
| @@ -1,27 +1,27 @@ | |||
| --- | |||
| eip: 615 | |||
| title: Subroutines and Static Jumps for the EVM | |||
| status: Draft | |||
| status: Last Call | |||
There was a problem hiding this comment.
review-period-end: is missing indeed
According to EIP-1 that's normally 14 days, but I suppose it's up to the author.
|
@nicksavers On whether changes should delay last call. Hardly any changes are substantial, and those are fixing small errors. Mainly I'm clarifying the intro material, (failing) to fix some spelling and formatting, and getting some opcode names right. |
|
@axic On branching off this repo. You are probably right, though it is very convenient, and we do it often enough we should probably discuss when it's appropriate. I'll continue to use this branch until it's merged. |
Suggested review-period-end in 14 days
|
Note that EIP-1702 has been merged and can be directly linked. |
|
@axic @nicksavers I fixed the EIP-1702 link and merged. Thanks! |
| @@ -45,7 +45,7 @@ The result is that all of the following validations and optimizations can be don | |||
|
|
|||
| ### Dependencies | |||
|
|
|||
| > **[EIP-1702](https://github.com/ethereum/EIPs/pull/1702). Generalized Account Versioning Scheme.** This proposal needs a versioning scheme to allow for its bytecode (and eventually eWasm bytecode) to be deployed with existing bytecode on the same blockchain. | |||
| > **[EIP-1702](http://eips.ethereum.org/EIPS/eip-1702). Generalized Account Versioning Scheme.** This proposal needs a versioning scheme to allow for its bytecode (and eventually eWasm bytecode) to be deployed with existing bytecode on the same blockchain. | |||
There was a problem hiding this comment.
Btw if this is a dependency, it should have been added to the requires header.
* Update eip-615.md * Update discussion-to link. * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md Suggested review-period-end in 14 days * Update eip-615.md
* Update eip-615.md * Update discussion-to link. * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md Suggested review-period-end in 14 days * Update eip-615.md
* Update eip-615.md * Update discussion-to link. * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md Suggested review-period-end in 14 days * Update eip-615.md
* Update eip-615.md * Update discussion-to link. * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md * Update eip-615.md Suggested review-period-end in 14 days * Update eip-615.md
Monday, July 14 would be a good day to start.