Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EIPs status based on ACD Call #67 #2226

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Change EIPs status based on ACD Call #67 #2226

merged 2 commits into from
Aug 15, 2019

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Aug 2, 2019

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1679 requires approval from one of (@5chdn, @axic)

@timbeiko
Copy link
Contributor Author

timbeiko commented Aug 7, 2019

Updated the EIP to use Istanbul 1 and Istanbul 2 similarly to the geth tracker: ethereum/go-ethereum#19919

@axic
Copy link
Member

axic commented Aug 11, 2019

Updated the EIP to use Istanbul 1 and Istanbul 2 similarly to the geth tracker:

Is this necessary? Can't see this reflected in the meeting notes under decision.

@timbeiko
Copy link
Contributor Author

timbeiko commented Aug 12, 2019 •
edited
Loading

@axic it was to avoid confusion. I'm not sure what is least confusing at this point: a whole bunch of EIPs in "Tenatively Accepted", or having the Istanbul 1/2 separation.

In the call, the consensus seemed to be that all the EIPs moved to Tentatively Accepted would be for a later fork, given how far we are in the process for the October one, but it wasn't clear cut and the notes don't reflect that.

I'm fine with merging either commit, but IMO it's best to have the EIP reflect the latest information. If it's easier to link back to the notes and just bundle all the EIPs in Tentatively Accepted, then let's do that.

@eip-automerger eip-automerger merged commit 226cf77 into ethereum:master Aug 15, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
@timbeiko @ilanolkies
Automatically merged updates to draft EIP(s) 1679 (ethereum#2226)
0f8d3df 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
@timbeiko @MadeofTin
Automatically merged updates to draft EIP(s) 1679 (ethereum#2226)
c10a5ed 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
BelfordZ pushed a commit to BelfordZ/EIPs that referenced this pull request Dec 13, 2019
@timbeiko @BelfordZ
Automatically merged updates to draft EIP(s) 1679 (ethereum#2226)
6e4f38d 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@timbeiko @tkstanczak
Automatically merged updates to draft EIP(s) 1679 (ethereum#2226)
6299352 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timbeiko @eip-automerger @axic