Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1191: Change status to Last Call #2234

Merged
merged 3 commits into from
Nov 1, 2019
Merged

EIP-1191: Change status to Last Call #2234

merged 3 commits into from
Nov 1, 2019

Conversation

juli
Copy link
Contributor

@juli juli commented Aug 10, 2019

Change status to Last Call and add reference to web3.js and ethereumjs-util implementations.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1191 state from Draft to Last Call

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ERC is lacking an Abstract and a Motivation section.

@axic axic changed the title Change status to Last Call EIP-1191: Change status to Last Call Sep 6, 2019
@juli juli requested a review from axic October 11, 2019 23:25
@axic
Copy link
Member

axic commented Nov 1, 2019

Please make sure to advertise this and gather sufficient agreement from adopters.

@axic axic merged commit 04fa20b into ethereum:master Nov 1, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
* Update eip-1191.md

* Adds Abstract and Motivation sections.

* adds review-period-end
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
* Update eip-1191.md

* Adds Abstract and Motivation sections.

* adds review-period-end
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* Update eip-1191.md

* Adds Abstract and Motivation sections.

* adds review-period-end
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* Update eip-1191.md

* Adds Abstract and Motivation sections.

* adds review-period-end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants