-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1191: Change status to Last Call #2234
Merged
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
axic
reviewed
Aug 11, 2019
axic
suggested changes
Aug 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ERC is lacking an Abstract and a Motivation section.
axic
approved these changes
Nov 1, 2019
Please make sure to advertise this and gather sufficient agreement from adopters. |
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
* Update eip-1191.md * Adds Abstract and Motivation sections. * adds review-period-end
MadeofTin
pushed a commit
to MadeofTin/EIPs
that referenced
this pull request
Nov 13, 2019
* Update eip-1191.md * Adds Abstract and Motivation sections. * adds review-period-end
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
* Update eip-1191.md * Adds Abstract and Motivation sections. * adds review-period-end
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
* Update eip-1191.md * Adds Abstract and Motivation sections. * adds review-period-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change status to Last Call and add reference to web3.js and ethereumjs-util implementations.