Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1: formatting fixes and clarifications #2236

Merged
merged 7 commits into from
Sep 15, 2019
Merged

Conversation

axic
Copy link
Member

@axic axic commented Aug 11, 2019

No description provided.

@axic axic marked this pull request as ready for review August 11, 2019 14:33
@axic axic requested review from nicksavers and Arachnid August 11, 2019 14:33
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1 is in state Active, not Draft or Last Call
  • EIP 2 is in state Final, not Draft or Last Call
  • File README.md is not an EIP
  • File eip-template.md is not an EIP
  • EIP 1812 requires approval from one of (@pelle)

* **Superseded** -- An EIP which was previously final but is no longer considered state-of-the-art. Another EIP will be in Final status and reference the Superseded EIP.
* :arrow_right: Draft -- Authors or new champions wishing to pursue this EIP can ask for changing it to Draft status.
* **Rejected** -- An EIP that is fundamentally broken or a Core EIP that was rejected by the Core Devs and will not be implemented. An EIP cannot move on from this state.
* **Active** -- This is similar to Final, but denotes an EIP which may be updated without changing its EIP number. An EIP cannot move on from this state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to clarify that this is just for 'special' EIPs like EIP1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2196 clarifies those parts.

@axic
Copy link
Member Author

axic commented Sep 5, 2019

@nicksavers @Arachnid any objections merging this?

@axic
Copy link
Member Author

axic commented Sep 10, 2019

@Arachnid @nicksavers @Souptacular @gcolvin can this be merged?

@axic
Copy link
Member Author

axic commented Sep 15, 2019

Merging as nobody was against this, one editor approved and it is mostly clarifications.

@axic axic merged commit 880184a into ethereum:master Sep 15, 2019
@axic axic deleted the eip1-fixes branch September 15, 2019 16:51
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
* EIP-1: make category field in EIP more clear

* Better heading in README

* EIP-2: fix typo in rendering

* EIP-1: clarify that an EIP can move from the Abandoned status to the Draft status

Also clarify that EIPs cannot move from the Rejected and Superseded states.

* EIP-1: rename WIP status to Idea

* EIP-1: change template formatting to fix markdown rendering

With angle brackets markdown renders them as HTML tags sometimes (depending on the rendering engine).

* EIP-1812: change copyright link to the correct CC0 link
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
* EIP-1: make category field in EIP more clear

* Better heading in README

* EIP-2: fix typo in rendering

* EIP-1: clarify that an EIP can move from the Abandoned status to the Draft status

Also clarify that EIPs cannot move from the Rejected and Superseded states.

* EIP-1: rename WIP status to Idea

* EIP-1: change template formatting to fix markdown rendering

With angle brackets markdown renders them as HTML tags sometimes (depending on the rendering engine).

* EIP-1812: change copyright link to the correct CC0 link
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* EIP-1: make category field in EIP more clear

* Better heading in README

* EIP-2: fix typo in rendering

* EIP-1: clarify that an EIP can move from the Abandoned status to the Draft status

Also clarify that EIPs cannot move from the Rejected and Superseded states.

* EIP-1: rename WIP status to Idea

* EIP-1: change template formatting to fix markdown rendering

With angle brackets markdown renders them as HTML tags sometimes (depending on the rendering engine).

* EIP-1812: change copyright link to the correct CC0 link
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* EIP-1: make category field in EIP more clear

* Better heading in README

* EIP-2: fix typo in rendering

* EIP-1: clarify that an EIP can move from the Abandoned status to the Draft status

Also clarify that EIPs cannot move from the Rejected and Superseded states.

* EIP-1: rename WIP status to Idea

* EIP-1: change template formatting to fix markdown rendering

With angle brackets markdown renders them as HTML tags sometimes (depending on the rendering engine).

* EIP-1812: change copyright link to the correct CC0 link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants