Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-684 to Byzantium Meta #2252

Closed
wants to merge 2 commits into from
Closed

Add EIP-684 to Byzantium Meta #2252

wants to merge 2 commits into from

Conversation

soc1c
Copy link
Contributor

@soc1c soc1c commented Aug 27, 2019

fix #2220

to my knowledge, all clients implement it

EIPS/eip-609.md Outdated Show resolved Hide resolved
@axic
Copy link
Member

axic commented Aug 28, 2020

There is a discussion in https://ethereum-magicians.org/t/eip-689-address-collision-of-contract-address-causes-exceptional-halt/3542 about this. I think we should do what was suggested in that discussion and then merge this.

I'd be against merging this PR as-is because currently all the "hard fork metas" are somewhat of a higher quality with linking to well-formatted EIPs. Compared to that this PR would link to a non-EIP-formatted link.

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make 684 into an EIP and not linking to an issue here.

@github-actions
Copy link

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Oct 28, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Nov 4, 2020
@hacker-DOM
Copy link

Imho something is better than nothing. It's confusing that 684 is not listed among Byzantium EIPs, even though it was part of it

@soc1c soc1c deleted the patch-4 branch February 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP-684 is missing from the repository
3 participants