-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ERC 1123 #2822
Deprecate ERC 1123 #2822
Conversation
c79b6e2
to
c17dcf6
Compare
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Deprecated isn't a valid EIP status. You can either mark this as abandoned if you no longer wish to pursue it, or you can push it through to Final. Currently there is a In the future, I recommend pushing EIPs to final when they are done as soon as possible, rather than leaving them as DRAFT indefinitely. |
ea2264a
to
b9db87c
Compare
EIPS/eip-1123.md
Outdated
type: Standards Track | ||
category: ERC | ||
created: 2018-06-01 | ||
replaces: 190 | ||
superseded by: 2678 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should have a dash and not a space.
b9db87c
to
adf1fb2
Compare
Maybe these rules are archaic and would benefit from a thorough review, but this is what it is today:
I think you have two options:
I would be interested to hear other thoughts on this, maybe there's a better way to handle this case or to introduce better rules/processes. |
Ahh, ok thanks for the explanation @axic - Since 1123 never received significant adoption among tooling, I'm leaning towards the first option and marking 1123 as abandoned. In terms of the rules, it seems to me to be a strict but fair process, I had just missed that this erc technically never made it past the |
adf1fb2
to
b31f242
Compare
I favor marking this as abandoned if you no longer wish to pursue it. I would like to see us add the Withdrawn status, but progress on that front is moving quite slowly and it isn't a valid state yet. |
EIPS/eip-1123.md
Outdated
type: Standards Track | ||
category: ERC | ||
created: 2018-06-01 | ||
replaces: 190 | ||
superseded-by: 2678 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superseded-by: 2678 |
superseded-by
is only valid on Final
EIPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, ok understood, thanks @MicahZoltu !
6de61d5
to
3ad1f42
Compare
@njgheorghita from an editor's standpoint this looks fine to me. Perhaps you want some feedback from @gnidan @pipermerriam @djrtwo if they oppose the change. |
This has my support. |
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
This ERC has been abandoned in favor of the EthPM V3 smart contract packaging standard defined in [ERC-2678](https://eips.ethereum.org/EIPS/eip-2678)
This ERC has been abandoned in favor of the EthPM V3 smart contract packaging standard defined in [ERC-2678](https://eips.ethereum.org/EIPS/eip-2678)
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: