Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ERC 1123 #2822

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Deprecate ERC 1123 #2822

merged 2 commits into from
Sep 4, 2020

Conversation

njgheorghita
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-automerger
Copy link

eip-automerger commented Jul 22, 2020

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1123 state from Draft to Abandoned

@MicahZoltu
Copy link
Contributor

Deprecated isn't a valid EIP status. You can either mark this as abandoned if you no longer wish to pursue it, or you can push it through to Final. Currently there is a Superceded status that can be set after Final, but the editors are currently talking about getting rid of that.

In the future, I recommend pushing EIPs to final when they are done as soon as possible, rather than leaving them as DRAFT indefinitely.

@njgheorghita njgheorghita force-pushed the deprecate-1123 branch 3 times, most recently from ea2264a to b9db87c Compare September 2, 2020 21:35
EIPS/eip-1123.md Outdated
type: Standards Track
category: ERC
created: 2018-06-01
replaces: 190
superseded by: 2678
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should have a dash and not a space.

@axic
Copy link
Member

axic commented Sep 2, 2020

Maybe these rules are archaic and would benefit from a thorough review, but this is what it is today:

  1. Only a Final standard can be superseded by another Final standard. It seems 2678 is not final.
  2. It would be bad form escalating this to final directly from draft and skipping the last call. Even if this was around forever.

I think you have two options:

  1. Marking this abandoned and explaining why.
  2. Marking 1123 and 2678, last call and getting them to final, lastly apply this changed of superseding to 1123.

I would be interested to hear other thoughts on this, maybe there's a better way to handle this case or to introduce better rules/processes.

@njgheorghita
Copy link
Contributor Author

Ahh, ok thanks for the explanation @axic - Since 1123 never received significant adoption among tooling, I'm leaning towards the first option and marking 1123 as abandoned. In terms of the rules, it seems to me to be a strict but fair process, I had just missed that this erc technically never made it past the Draft stage.

EIPS/eip-1123.md Outdated Show resolved Hide resolved
@MicahZoltu
Copy link
Contributor

I favor marking this as abandoned if you no longer wish to pursue it. I would like to see us add the Withdrawn status, but progress on that front is moving quite slowly and it isn't a valid state yet.

EIPS/eip-1123.md Outdated
type: Standards Track
category: ERC
created: 2018-06-01
replaces: 190
superseded-by: 2678
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
superseded-by: 2678

superseded-by is only valid on Final EIPs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, ok understood, thanks @MicahZoltu !

@axic
Copy link
Member

axic commented Sep 3, 2020

@njgheorghita from an editor's standpoint this looks fine to me. Perhaps you want some feedback from @gnidan @pipermerriam @djrtwo if they oppose the change.

@pipermerriam
Copy link
Member

This has my support.

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
@MicahZoltu MicahZoltu merged commit e8831d2 into ethereum:master Sep 4, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
This ERC has been abandoned in favor of the EthPM V3 smart contract packaging standard defined in [ERC-2678](https://eips.ethereum.org/EIPS/eip-2678)
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
This ERC has been abandoned in favor of the EthPM V3 smart contract packaging standard defined in [ERC-2678](https://eips.ethereum.org/EIPS/eip-2678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants