-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch validator to eipv #2860
Switch validator to eipv #2860
Changes from all commits
bff86e3
533bb1a
0cbcc94
f6aeded
e25dd51
838d6a7
531fc72
a04f6ae
315ae8a
e716f61
208dd1a
4ee9314
f4219d8
32ffc82
6643038
322db84
29ad8dc
f7f4ff5
c801d96
ecc7481
cfc26d6
a853f50
62b4896
b88899c
f066a78
a41e4ae
db83eec
57c9e28
c3da24f
64bc976
d038a25
75986bd
39d6036
4c7851a
0fa9d62
3d2a8ac
f48a465
81e7d61
7a25c9b
128404e
d274a9f
2da2916
87f75fc
89af85b
35da03e
bb0d5b5
45c06d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ title: EIP Purpose and Guidelines | |
status: Active | ||
type: Meta | ||
author: Martin Becze <mb@ethereum.org>, Hudson Jameson <hudson@ethereum.org>, and others | ||
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not clear what purpose this URL served here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have changed this file locally just never submitted a PR. My understanding it tries to signal "look at the history". What I opted for was "Martin ..., Hudson ..., et al." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I see, it was supposed to be a part of the authors field. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we change the authors for EIP-1 to just "Contributors Like You". 🚎 /not-🚎 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have a strong feeling towards this, but IMO it's outside the scope of this PR. |
||
created: 2015-10-27 | ||
updated: 2015-12-07, 2016-02-01, 2018-03-21, 2018-05-29, 2018-10-17, 2019-05-19, 2019-12-04, 2020-06-17 | ||
--- | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1355 | ||
title: Ethash 1a | ||
author: Paweł Bylica (@chfast) <pawel@ethereum.org>, Jean M. Cyr (@jean-m-cyr) | ||
author: Paweł Bylica (@chfast), Jean M. Cyr (@jean-m-cyr) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should include the person twice in this case, so that they are a valid author both by email and by GitHub handle? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (same comment elsewhere where this change was made) |
||
discussions-to: https://ethereum-magicians.org/t/eip-1355-ethash-1a/1167 | ||
status: Abandoned | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
--- | ||
eip: 196 | ||
title: Precompiled contracts for addition and scalar multiplication | ||
on the elliptic curve alt_bn128 | ||
title: Precompiled contracts for addition and scalar multiplication on the elliptic curve alt_bn128 | ||
author: Christian Reitwiessner<chris@ethereum.org> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^^ |
||
type: Standards Track | ||
category: Core | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that the validator is currently not ensuring that titles are less than the max specified length and that each EIP has a
discussions-to
field. This is due to the number of non-conforming EIPs. I think formally increasing the max title length to support all current EIPs and then turning on the check is acceptable. With regards to thediscussions-to
field, there are some options:discussions-to
and only check new onesI prefer
1
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer 1 or 2. Anything that gets the system into a more standardized state so we can reliably use the bot going forward and don't need to maintain code to support malformed ancient EIPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, prefer 1 or 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow the
1
path.