Update eip-2535.md #2886
Merged
Update eip-2535.md #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lightclient
requested changes
Aug 20, 2020
EIPS/eip-2535.md
Outdated
| 1. Build trust over time by showing all changes made to a diamond. | ||
| 2. A stable diamond address that provides needed functionality. | ||
| 3. The ability to develop and improve an application over time with an upgradeable diamond and then make it immutable and trustless if desired. | ||
| When an external function is called on a diamond its fallback function is exectued. The fallback function finds in the `selectorToFacet` mapping which facet has the function that has been called and then executes that function from the facet using `delegatecall`. |
There was a problem hiding this comment.
Suggested change
| When an external function is called on a diamond its fallback function is exectued. The fallback function finds in the `selectorToFacet` mapping which facet has the function that has been called and then executes that function from the facet using `delegatecall`. | |
| When an external function is called on a diamond its fallback function is executed. The fallback function finds in the `selectorToFacet` mapping which facet has the function that has been called and then executes that function from the facet using `delegatecall`. |
There was a problem hiding this comment.
The bot won't auto-merge this until the spelling error mentioned above is fixed.
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
|
@MicahZoltu @lightclient The pull request isn't getting merged because it is using two images. Do you know how to make it so that the pull request gets merged with the two images? I am using the images as described in eip-1: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md#eip-formats-and-templates |
|
This is standard, @MicahZoltu will be able to manually merge this PR. The bot is unfortunately not aware of the owners of files other than the EIP itself. |
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
* Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * eip-2535.md * eip-2535.md, fixed typo.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
* Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * Update eip-2535.md * eip-2535.md * eip-2535.md, fixed typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.