Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-2929: clarifications #2998

Merged
merged 1 commit into from
Sep 26, 2020
Merged

EIP-2929: clarifications #2998

merged 1 commit into from
Sep 26, 2020

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Sep 24, 2020

Contains a few clarifications

  • Request from @shamatar to be more clear in the abstract that some ops become cheaper,
  • Clarification (maybe unnecessary), due to an error that was present in geth, found by @shemnon
  • Finding by @shemnon that geth incorrectly had not updated a composite variable

@holiman holiman requested a review from vbuterin September 24, 2020 07:39
@holiman holiman marked this pull request as ready for review September 24, 2020 12:17
@vbuterin
Copy link
Contributor

Looks good to me! 👍

@holiman holiman merged commit 2adc96a into ethereum:master Sep 26, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@holiman @tkstanczak
EIP-2929: clarifications (ethereum#2998)
26a5b32
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@holiman @Arachnid
EIP-2929: clarifications (ethereum#2998)
53d0c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuterin vbuterin Awaiting requested review from vbuterin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @vbuterin