Create draft EIP-symbol #3014
Merged
Create draft EIP-symbol #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested changes
Sep 30, 2020
MicahZoltu
approved these changes
Oct 1, 2020
EIPS/eip-symbol.md
Outdated
Comment on lines
46
to
50
| ## Rationale | ||
| <!-- The rationale fleshes out the specification by describing what motivated the design and why particular design decisions were made. It should describe alternate designs that were considered and related work, e.g. how the feature is supported in other languages. The rationale may also provide evidence of consensus within the community, and should discuss important objections or concerns raised during discussion. --> | ||
| (Similar to https://eips.ethereum.org/EIPS/eip-695 and symbol from https://eips.ethereum.org/EIPS/eip-20) | ||
|
|
||
| todo |
There was a problem hiding this comment.
Maybe mention why eth_symbol instead of eth_nativeCurrencySymbol?
There was a problem hiding this comment.
I now mentioned it but I'm open for alternatives and more discussion.
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
lightclient
requested changes
Oct 1, 2020
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
lightclient
requested changes
Oct 1, 2020
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
lightclient
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Apologies @PeterTheOne, I made a mistake on my previous review. The relative links should also have *.md endings. Otherwise this looks good.
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@lightclient no problem, you have been very helpful! thnx |
MicahZoltu
approved these changes
Oct 3, 2020
| @@ -0,0 +1,48 @@ | |||
| --- | |||
| eip: 3014 | |||
| title: Create `eth_symbol` method for JSON-RPC | |||
There was a problem hiding this comment.
Suggested change
| title: Create `eth_symbol` method for JSON-RPC | |
| title: `eth_symbol` JSON-RPC method |
Consider tightening up the title to be a bit more terse.
There was a problem hiding this comment.
good point #3018
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Add `eth_symbol` method to the JSON-RPC that returns the symbol of the native coin of the network.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Add `eth_symbol` method to the JSON-RPC that returns the symbol of the native coin of the network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #3012