Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation section to EIP #3582

Closed
wants to merge 2 commits into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 20, 2021

Adding an implementation section to the EIP EIP-778, per request from @fulldecent:
ethereum/devp2p#43 (comment)

@alita-moore
Copy link
Contributor

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - eip-778.md requires approval from one of (fjl)

@fjl

@MicahZoltu
Copy link
Contributor

MicahZoltu commented May 20, 2021

Sorry for the confusion, but Implementation section is no longer part of the template and we (editors) generally recommend against external links like this as they are often not relevant to future readers.

@atoulme
Copy link
Contributor Author

atoulme commented May 20, 2021

OK, let me know - close this or rewrite with no links?

@MicahZoltu
Copy link
Contributor

OK, let me know - close this or rewrite with no links?

My recommendation is to close. This isn't final because either no one has submitted a PR to move it to final or the authors haven't approved any such PRs. This EIP doesn't align with our current policies, but it is "grandfathered in" due to its age (policies were different back when it was created).

@fulldecent
Copy link
Contributor

I appreciate this, thank you

@lightclient
Copy link
Member

Now that EIP-778 is final, I'm going to close this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants