-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1202 stagnant (2021-Sep-19th@23.8.11) #4193
Conversation
@xinbenlv can you leave a request changes review? the bot can't interpret it otherwise |
@alita-moore, already did in #4190 |
also @MicahZoltu do we want a feature to also consider PRs open against the file? |
@xinbenlv what I'm saying is can you please leave a negative review on this PR; it can be used later for determining if it should open a PR |
love to comply, how do i do that(what do you mean "when you say leave a negative review"?) can you give example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should only open these if there are no pending PRs against the EIP. |
We shouldn't be leaving these open once an author has created a PR to update. Otherwise we just end up with a double-PRs against such EIPs which can be confusing. |
Okay, do you mind adding this as a feature request in the eip-bot repo? |
@xinbenlv You may see the bot open another of these next week, which we apologize for. Just link to your open PR and we'll close the PR just like here. ethereum/EIP-Bot#17 will fix this, but it may not be implemented before the next round of bot actions. |
This EIP has not been active since (2020-Sep-29th@23.22.43); which, is greater than the allowed time of 6 months.
authors: @xinbenlv, @evbots, @yingogobot