Replace `resolution`, `superseded-by` and `replaces` with `withdrawal-reason`. #4198

axic · 2021-09-22T22:06:37Z

This is mostly for discussion.

…ution)

MicahZoltu · 2021-09-26T03:48:56Z

Good discussion. You want to mark this as ready for review so we can merge it @axic?

alita-moore · 2021-09-26T07:49:23Z

this a good test for the bot, btw; it supports multiple files now

eth-bot · 2021-10-20T15:29:15Z

EIP file name must be eip-###.md

alita-moore · 2021-10-20T15:30:53Z

-_-

MicahZoltu · 2021-10-20T15:33:27Z

eip-1706.md:	unknown preamble field
eip-3338.md:	unknown preamble field
eip-3382.md:	unknown preamble field

@alita-moore Is this something you can fix? This is sfrom Travis CI, I'm not sure where the code for that lives. 😖

alita-moore · 2021-10-20T15:34:09Z

most likely there are issues with the name of the headers

lightclient · 2021-10-20T15:34:18Z

That's eipv, I can update it.

alita-moore · 2021-10-20T15:34:36Z

i.e. withdrawal-reason is unknown

alita-moore · 2021-10-20T15:35:24Z

one sec

MicahZoltu · 2021-10-29T11:33:24Z

@alita-moore The bot isn't liking this PR, and it isn't clear why from the error:

An Exception Occured While Linting: 
YAMLException: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
Error: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
(node:1607) UnhandledPromiseRejectionWarning: YAMLException: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
    at generateError (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:167:10)
    at throwError (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:173:9)
    at readBlockMapping (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1027:9)
    at composeNode (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1359:12)
    at readDocument (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1525:3)
    at loadDocuments (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1588:5)
    at load (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1614:19)
    at safeLoad (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1637:10)
    at parse (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/front-matter/index.js:64:20)
    at extractor (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/front-matter/index.js:26:12)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1607) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1607) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
eip-3338.md passed!
Error: Process completed with exit code 1.

Also, we should fix this so it isn't an unhandled rejection, we should be capturing the error itself rather than silently crashing the app and relying on the unhandled rejection handler noticing it.

Parsing breaks on it I think.

alita-moore · 2021-10-29T11:58:02Z

@alita-moore The bot isn't liking this PR, and it isn't clear why from the error:

An Exception Occured While Linting: 
YAMLException: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
Error: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
(node:1607) UnhandledPromiseRejectionWarning: YAMLException: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 4, column 152:
     ... entheses or triangular brackets): FirstName LastName (@GitHubUse ... 
                                         ^
    at generateError (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:167:10)
    at throwError (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:173:9)
    at readBlockMapping (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1027:9)
    at composeNode (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1359:12)
    at readDocument (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1525:3)
    at loadDocuments (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1588:5)
    at load (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1614:19)
    at safeLoad (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/js-yaml/lib/js-yaml/loader.js:1637:10)
    at parse (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/front-matter/index.js:64:20)
    at extractor (/home/runner/work/_actions/ethereum/EIP-Bot/d627d305e33d8cdfe0310588ba74670d4a882600/node_modules/front-matter/index.js:26:12)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1607) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1607) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
eip-3338.md passed!
Error: Process completed with exit code 1.

Also, we should fix this so it isn't an unhandled rejection, we should be capturing the error itself rather than silently crashing the app and relying on the unhandled rejection handler noticing it.

Good idea. I'll standardize the error handling.

axic · 2021-11-02T20:13:01Z

Thanks all for getting this merged!

…-reason`. (ethereum#4198) * 1: add the withdrawal-reason field to the preamble * Drop all the deprecated header fields (replaces, superseded-by, resolution) * update some EIPs * Update some more EIPs * Removes colon from template header data Parsing breaks on it I think. Co-authored-by: Micah Zoltu <micah@zoltu.net>

axic added 4 commits September 22, 2021 23:12

1: add the withdrawal-reason field to the preamble

b10a00a

Drop all the deprecated header fields (replaces, superseded-by, resol…

ff7c725

…ution)

update some EIPs

03d13c6

Update some more EIPs

d43f30b

axic force-pushed the eip-1-reason branch from 059fee0 to d43f30b Compare September 22, 2021 22:12

MicahZoltu approved these changes Sep 24, 2021

View reviewed changes

lightclient approved these changes Sep 25, 2021

View reviewed changes

axic mentioned this pull request Oct 15, 2021

EIP-1: Removes preamble content that isn't used. #4371

Closed

lightclient marked this pull request as ready for review October 20, 2021 15:27

MicahZoltu closed this Oct 20, 2021

MicahZoltu reopened this Oct 20, 2021

lightclient mentioned this pull request Oct 20, 2021

Remove updated from EIP-1 #4384

Closed

eth-bot enabled auto-merge (squash) October 20, 2021 15:28

alita-moore mentioned this pull request Oct 20, 2021

[bug] bot mentions only one exception instead of per file ethereum/EIP-Bot#23

Closed

This was referenced Oct 20, 2021

Update preamble fields ethereum/eipv#33

Merged

Bump eipv to v0.3.0 #4386

Merged

MicahZoltu closed this Oct 28, 2021

auto-merge was automatically disabled October 28, 2021 18:43
Pull request was closed

MicahZoltu reopened this Oct 28, 2021

eth-bot enabled auto-merge (squash) October 28, 2021 18:43

Removes colon from template header data

ea029f2

Parsing breaks on it I think.

alita-moore mentioned this pull request Oct 29, 2021

[bug] bot failing on PR ethereum/EIP-Bot#25

Closed

MicahZoltu disabled auto-merge October 29, 2021 12:15

MicahZoltu merged commit 3cf5268 into ethereum:master Oct 29, 2021

axic deleted the eip-1-reason branch November 2, 2021 20:13

axic mentioned this pull request Nov 4, 2021

Update the page to display withdrawal-reason #4420

Merged

axic mentioned this pull request Dec 19, 2022

Add a Superseded status #5265

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `resolution`, `superseded-by` and `replaces` with `withdrawal-reason`. #4198

Replace `resolution`, `superseded-by` and `replaces` with `withdrawal-reason`. #4198

axic commented Sep 22, 2021

MicahZoltu commented Sep 26, 2021

alita-moore commented Sep 26, 2021

eth-bot commented Oct 20, 2021 •

edited

Loading

alita-moore commented Oct 20, 2021

MicahZoltu commented Oct 20, 2021

alita-moore commented Oct 20, 2021

lightclient commented Oct 20, 2021

alita-moore commented Oct 20, 2021

alita-moore commented Oct 20, 2021

MicahZoltu commented Oct 29, 2021

alita-moore commented Oct 29, 2021

axic commented Nov 2, 2021

Replace resolution, superseded-by and replaces with withdrawal-reason. #4198

Replace resolution, superseded-by and replaces with withdrawal-reason. #4198

Conversation

axic commented Sep 22, 2021

MicahZoltu commented Sep 26, 2021

alita-moore commented Sep 26, 2021

eth-bot commented Oct 20, 2021 • edited Loading

alita-moore commented Oct 20, 2021

MicahZoltu commented Oct 20, 2021

alita-moore commented Oct 20, 2021

lightclient commented Oct 20, 2021

alita-moore commented Oct 20, 2021

alita-moore commented Oct 20, 2021

MicahZoltu commented Oct 29, 2021

alita-moore commented Oct 29, 2021

axic commented Nov 2, 2021

Replace `resolution`, `superseded-by` and `replaces` with `withdrawal-reason`. #4198

Replace `resolution`, `superseded-by` and `replaces` with `withdrawal-reason`. #4198

eth-bot commented Oct 20, 2021 •

edited

Loading