Reformat EIP1967 to match requirements from EIP1 #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add inline reference implementation - Change simple summary section to description header field - Move extraneous Beacon section to within the Specification - Add new Security Considerations section - Update some outdated links
|
All tests passed; auto-merging... |
|
@spalladino there are a few spelling errors here. Once fixed, this should auto-merge. |
auto-merge was automatically disabled
November 16, 2021 15:55
Head branch was pushed to by a user without write access
|
@lightclient thanks for the heads-up, just fixed them! |
|
Hey @axic, what would be the next steps to push forward this EIP? |
|
@spalladino Submit a PR that changes the status from Draft to Review if you are no longer actively iterating on it. A reviewer will review the EIP again (a bit more thoroughly than the first time) and either give feedback or approve. Once it is in Review, that is a good opportunity to solicit feedback from a wider audience before moving to Last Call and then eventually Final. |
|
Done, thanks @MicahZoltu! #4495 |
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* Reformat EIP1967 to match requirements from EIP1 - Add inline reference implementation - Change simple summary section to description header field - Move extraneous Beacon section to within the Specification - Add new Security Considerations section - Update some outdated links * Fix spelling mistakes on code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @axic