Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update author format to preferred name + GitHub username format, Vitalik #4559

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

fulldecent
Copy link
Contributor

Updating EIPs from this author to use preferred author citation format.

REFERENCES:

@eth-bot
Copy link
Collaborator

eth-bot commented Dec 15, 2021

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) EIPS/eip-101.md

  • eip-101.md has no identifiable authors who can approve the PR (only considering the base version)

(fail) EIPS/eip-198.md

  • eip-198.md has no identifiable authors who can approve the PR (only considering the base version)

(fail) EIPS/eip-2.md

  • eip-2.md has no identifiable authors who can approve the PR (only considering the base version)

(fail) EIPS/eip-7.md

  • eip-7.md has no identifiable authors who can approve the PR (only considering the base version)

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from me, but probably @vbuterin should give a nod too.

@axic
Copy link
Member

axic commented Dec 15, 2021

@MicahZoltu @lightclient if you think this can merged as-is, please do. I think it should be fine as the author is identifyable, but this is a retroactive application of the EIP-1 rule if enforced by an editor.

@MicahZoltu
Copy link
Contributor

Normally I am not a fan of changing the author line without author approval, but in this case the author is a high profile individual and their recent EIPs use the GitHub syntax suggesting that they are generally OK with that over their email address so I am willing to make an exception here.

@MicahZoltu MicahZoltu merged commit 05f0b25 into ethereum:master Dec 19, 2021
PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants