-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-918: Move from Stagnant to Draft #4729
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) EIPS/eip-918.md
|
@jlogelin kindly add the github username for atleast one of the author, instead of the e-mail id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlogelin please review EIP-1 and the EIP template. The format has changed since this EIP was created. It will need to be updated before moving it to last call.
(fail) EIPS/eip-918.md
@mryalamanchi please advise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
I verified that the author change is legitimate. You'll need to manually merge once the above spelling error is fixed and CI passes @lightclient. |
There are now merge conflicts @jlogelin can you please update so we can merge? |
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Closing since the author hasn't been seen in >3 months (the stale threshold). |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: