Spell out mission statement, fixes #1128 #4748
Conversation
All tests passed; auto-merging...(pass) README.md
|
There was a problem hiding this comment.
Probably best to remove this whitespace at the end, otherwise the change looks good. Travis CI is failing and atm can't load to see why. Would also be good to have @axic or @MicahZoltu lay eyes on this.
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
fulldecent
force-pushed
the
mission-statement
branch
from
b8099b4
to
eafba69
Compare
|
Thank you. Rebased. Maybe that will jiggle it into being accepted by the robots. |
| ```sh | ||
| $ gem install bundler | ||
| ``` | ||
| ```sh |
There was a problem hiding this comment.
Nit: why do these need to be indented?
There was a problem hiding this comment.
This renders so that the code fence is part of the step.
Without indenting, the code fence is not semantically part of the list of instructions.
README.md
Outdated
|
|
||
| Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, including core protocol specifications, client APIs, and contract standards. **Browse all current and draft EIPs on [the official EIP site](https://eips.ethereum.org/).** | ||
| This repository tracks the ongoing improvements to Ethereum. It contains: |
There was a problem hiding this comment.
I think "tracks" is a very loose term here and could be understood differently, i.e. "this is the sole place to get information about what is being worked on for Ethereum", which is clearly the wrong impression to give.
There was a problem hiding this comment.
Remove definite article at 970c2a9.
Now we're tracking improvements instead of tracking (all of) the improvements.
There was a problem hiding this comment.
I can't say it is perfect, but I have no good suggestions.
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
|
Looks like we have tentative approval from multiple editors, so I'm going to merge this. |
* Spell out mission statement, fixes ethereum#1128 * Update README.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Remove definite article against "tracks" * Update README.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update README.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update README.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Related to EIPIP meeting https://github.com/ethereum-cat-herders/EIPIP/issues/101#issuecomment-1011094223
Please accept this PR and also update the repository description from:
to
This PR takes inspiration from https://github.com/apple/swift-evolution