Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advise against external links & add myself as an active editor #4872

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Mar 4, 2022

External links aren't durable, and may not necessarily permit redistribution. Some links may be durable and permit redistribution, but determining which links are/do is a subjective and onerous task for editors.

That said, I've chosen SHOULD NOT over MUST NOT to allow for special cases.

Note to editors: Signal approval with a comment, just in case the bot auto-merges on approval.

@eth-bot
Copy link
Collaborator

eth-bot commented Mar 4, 2022

All tests passed; auto-merging...

(pass) eip-1.md

classification
updateEIP
  • passed!

@MicahZoltu
Copy link
Contributor

My name is Micah, I support this change.

@gcolvin
Copy link
Contributor

gcolvin commented Mar 6, 2022

I think external references should be rare but not forbidden. So I think we need to be clear about when and how to break the general rule. Normative links should of course not be a problem -- they are logically part of the specification. Informative links should be used rarely, and sparely even so. One link often suffices to put a specification in context.

When external links are used, they should be as authoritative and stable as possible. When stable links are unavailable consider adding the page to the Internet Archive or adding its contents to assets . A proper References section will be needed for external links, which would also serve to mitigate link rot. The references should follow same format that we use for our own EIPs.

@MicahZoltu
Copy link
Contributor

My issue with having a fuzzy process like you have described @gcolvin is that we don't currently have enough active editors to keep up on it and do the necessary due diligence for what is acceptable and what isn't. On average, I would guess that every EIP contains 1-2 links initially (before I review it), and I think requiring editors to review every single one of these is too much of a burden. On top of that, I have found that when you point at a fuzzy rule for the reason for not allowing something the authors tend to question it/fight back and you have to engage in what usually is a very long debate about whether "A tweet or Reddit post on Internet Archive is an allowable link".

@SamWilsn SamWilsn changed the title Ban external links & add myself as an active editor Advise against external links & add myself as an active editor Mar 6, 2022
@SamWilsn
Copy link
Contributor Author

SamWilsn commented Mar 6, 2022

I think external references should be rare but not forbidden.

I agree. I can imagine some cases that might require an external link (ex. to a large dataset) and straight up forbidding them is probably not the best idea. To that end, I've used SHOULD NOT in this PR, and not MUST NOT so that editors have some leeway in how this rule is applied.

So I think we need to be clear about when and how to break the general rule.

Also agreed, though I don't think we need to formalize those rules today. Plus, like @MicahZoltu said, the more complex the rules, the more work it creates for editors.

When external links are used, they should be as authoritative and stable as possible.

Determining which sources are authoritative and stable is definitely an undertaking. Should the Internet Archive be considered stable, even considering they've been sued by book publishers in recent history? What about IPFS links? External git repositories?

Plus there's the issue of licenses. Theoretically, I would like any random user to be able to take a backup of the EIPs repository and carry it around on a USB stick, and to be able to share that content with anyone else. EIPs themselves are CC0-1.0, so that isn't an issue, but external links can be any license, adding to the complexity for editors.

@gcolvin
Copy link
Contributor

gcolvin commented Mar 6, 2022

Note: I'm happy to merge this PR as is and make my own for the further changes I'd like to see.

I've used SHOULD NOT in this PR, and not MUST NOT so that editors have some leeway in how this rule is applied.

I agree with that.

... I don't think we need to formalize those rules today. Plus, like @MicahZoltu said, the more complex the rules, the more work it creates for editors.

About all I have in mind is the distinction between normative and informative references and the format of the References for outside links. I can't see formalizing more than that.

Determining which sources are authoritative and stable is definitely an undertaking

For normative references it's not that hard -- these are published standards, and the publisher generally maintains a stable web site. For informative references it's more work but also not such a big deal if the link rots -- the spec remains complete, just harder for some readers to understand. And having a proper References section means that searches for title and author will often resolve the broken link. (And yes, in general, don't copy stuff to assets that we haven't the right to republish.)

@@ -185,6 +185,10 @@ The `created` header records the date that the EIP was assigned a number. Both h

EIPs may have a `requires` header, indicating the EIP numbers that this EIP depends on.

## Linking to External Resources

Links to external resources **SHOULD NOT** be included. External resources may disappear, move, or change unexpectedly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing "external resources" to "non-normative external resources."

@axic
Copy link
Member

axic commented Mar 7, 2022

How was this merged after a single approval? 😅

@SamWilsn
Copy link
Contributor Author

SamWilsn commented Mar 7, 2022

How was this merged after a single approval? sweat_smile

I think I counted as an approval.

@MicahZoltu
Copy link
Contributor

PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
…eum#4872)

* Add myself as an active editor

* Advise against external links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants